Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: runtime/observatory/lib/src/elements/script_ref.dart

Issue 1122503003: Display isolate message queue in Observatory debugger (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/script_ref.dart
diff --git a/runtime/observatory/lib/src/elements/script_ref.dart b/runtime/observatory/lib/src/elements/script_ref.dart
index 2f30e26b38b299c4268635f42e52dd687aa7040d..96e969c701de81c7039e80a8a44f2572f225b4dc 100644
--- a/runtime/observatory/lib/src/elements/script_ref.dart
+++ b/runtime/observatory/lib/src/elements/script_ref.dart
@@ -10,7 +10,7 @@ import 'service_ref.dart';
@CustomTag('script-ref')
class ScriptRefElement extends ServiceRefElement {
- @published int pos = -1;
+ @published int pos = null;
turnidge 2015/05/04 20:11:51 I guess it is null by default, huh.
Cutch 2015/05/04 20:18:57 Done.
String get hoverText {
if (ref == null) {
@@ -34,7 +34,7 @@ class ScriptRefElement extends ServiceRefElement {
if (ref == null) {
return super.name;
}
- if (pos >= 0) {
+ if ((pos != null) && (pos >= 0)) {
if (ref.loaded) {
// Script is loaded, get the line number.
Script script = ref;
@@ -51,7 +51,7 @@ class ScriptRefElement extends ServiceRefElement {
if (ref == null) {
return super.url;
}
- if (pos >= 0) {
+ if ((pos != null) && (pos >= 0)) {
if (ref.loaded) {
return '${super.url}---pos=${pos}';
} else {

Powered by Google App Engine
This is Rietveld 408576698