Display isolate message queue in Observatory debugger

runtime/observatory/lib/src/elements/debugger.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library debugger_page_element;
 
 import 'dart:async';
 import 'dart:html';
 import 'observatory_element.dart';
 import 'package:observatory/app.dart';
@@ skipping 1189 matching lines @@
     $['commandline'].debugger = debugger;
     debugger.init();
   }
 
 }
 
 @CustomTag('debugger-stack')
 class DebuggerStackElement extends ObservatoryElement {
   @published Isolate isolate;
   @observable bool hasStack = false;
+  @observable bool hasMessages = false;
   @observable bool isSampled = false;
   @observable int currentFrame;
   ObservatoryDebugger debugger;
 
   _addFrame(List frameList, ObservableMap frameInfo) {
     DebuggerFrameElement frameElement = new Element.tag('debugger-frame');
     frameElement.frame = frameInfo;
 
     if (frameInfo['depth'] == currentFrame) {
       frameElement.setCurrent(true);
     } else {
       frameElement.setCurrent(false);
     }
 
     var li = new LIElement();
     li.classes.add('list-group-item');
     li.children.insert(0, frameElement);
 
     frameList.insert(0, li);
   }
 
-  void updateStack(ServiceMap newStack, ServiceEvent pauseEvent) {
+  _addMessage(List messageList, ServiceMap messageInfo) {
+    DebuggerMessageElement messageElement = new Element.tag('debugger-message');
+    messageElement.message = messageInfo;
+
+    var li = new LIElement();
+    li.classes.add('list-group-item');
+    li.children.insert(0, messageElement);
+
+    messageList.add(li);
+  }
+
+  void updateStackFrames(ServiceMap newStack) {
     List frameElements = $['frameList'].children;
     List newFrames = newStack['frames'];
 
     // Remove any frames whose functions don't match, starting from
     // bottom of stack.
     int oldPos = frameElements.length - 1;
     int newPos = newFrames.length - 1;
     while (oldPos >= 0 && newPos >= 0) {
       if (!frameElements[oldPos].children[0].matchFrame(newFrames[newPos])) {
         // The rest of the frame elements no longer match.  Remove them.
@@ skipping 26 matching lines @@
       }
     }
     assert(frameElements.length == newFrames.length);
 
     if (frameElements.isNotEmpty) {
       for (int i = newCount; i < frameElements.length; i++) {
         frameElements[i].children[0].updateFrame(newFrames[i]);
       }
     }
 
+    hasStack = frameElements.isNotEmpty;
+  }
+
+  void updateStackMessages(ServiceMap newStack) {
+    List messageElements = $['messageList'].children;
+    List newMessages = newStack['messages'];
+
+    // Remove any extra message elements.
+    if (messageElements.length > newMessages.length) {
+      // Remove old messages from the front of the queue.
+      int removeCount = messageElements.length - newMessages.length;
+      for (int i = 0; i < removeCount; i++) {
+        messageElements.removeAt(0);
+      }
+    }
+
+    // Add any new messages to the tail of the queue.
+    int newStartingIndex = messageElements.length;
+    if (messageElements.length < newMessages.length) {
+      for (int i = newStartingIndex; i < newMessages.length; i++) {
+        _addMessage(messageElements, newMessages[i]);
+      }
+    }
+    assert(messageElements.length == newMessages.length);
+
+    if (messageElements.isNotEmpty) {
+      // Update old messages.
+      for (int i = 0; i < newStartingIndex; i++) {
+        messageElements[i].children[0].updateMessage(newMessages[i]);
+      }
+    }
+
+    hasMessages = messageElements.isNotEmpty;
+  }

[turnidge, 2015/05/04 17:47:12]

Nice.

[Cutch, 2015/05/04 19:56:51]

Acknowledged.

+
+  void updateStack(ServiceMap newStack, ServiceEvent pauseEvent) {
+    updateStackFrames(newStack);
+    updateStackMessages(newStack);
     isSampled = pauseEvent == null;
-    hasStack = frameElements.isNotEmpty;
   }
 
   void setCurrentFrame(int value) {
     currentFrame = value;
     List frameElements = $['frameList'].children;
     for (var frameElement in frameElements) {
       var dbgFrameElement = frameElement.children[0];
       if (dbgFrameElement.frame['depth'] == currentFrame) {
         dbgFrameElement.setCurrent(true);
       } else {
@@ skipping 103 matching lines @@
           frameOuter.classes.add('shadow');
         } else {
           expanded = false;
           frameOuter.classes.remove('shadow');
         }
         busy = false;
       });
   }
 }
 
+@CustomTag('debugger-message')

[turnidge, 2015/05/04 17:47:12]

I wonder if we can share more code between debugger-frame and debuggr-message. 
Not for this CL.

[Cutch, 2015/05/04 19:56:51]

Acknowledged.

+class DebuggerMessageElement extends ObservatoryElement {
+  @published ServiceMap message;
+  @observable ServiceObject preview;
+
+  // Is this the current message?
+  bool _current = false;
+
+  // Has this message been pinned open?
+  bool _pinned = false;
+
+  void setCurrent(bool value) {
+    _current = value;
+    var messageOuter = $['messageOuter'];
+    if (_current) {
+      messageOuter.classes.add('current');
+      expanded = true;
+      messageOuter.classes.add('shadow');
+      scrollIntoView();
+    } else {
+      messageOuter.classes.remove('current');
+      if (_pinned) {
+        expanded = true;
+        messageOuter.classes.add('shadow');
+      } else {
+        expanded = false;
+        messageOuter.classes.remove('shadow');
+      }
+    }
+  }
+
+  @observable String scriptHeight;
+  @observable bool expanded = false;
+  @observable bool busy = false;
+
+  DebuggerMessageElement.created() : super.created();
+
+  void updateMessage(ServiceMap newMessage) {
+    bool should_reset =

[turnidge, 2015/05/04 17:47:12]

camelCase

Also, could call it messageChanged instead of shouldReset.

[Cutch, 2015/05/04 19:56:51]

Done.

+        (message['messageObjectId'] != newMessage['messageObjectId']);
+    message['depth'] = newMessage['depth'];
+    message['handlerFunction'] = newMessage['handlerFunction'];
+    message['handlerScript'] = newMessage['handlerScript'];
+    message['messageObjectId'] = newMessage['messageObjectId'];
+    if (should_reset) {
+      // Message object id has changed: clear preview and collapse.
+      preview = null;
+      if (expanded) {
+        toggleExpand(null, null, null);
+      }
+    }
+  }
+
+  Script get script => message['handlerScript'];
+
+  @override
+  void attached() {
+    super.attached();
+    int windowHeight = window.innerHeight;
+    scriptHeight = '${windowHeight ~/ 1.6}px';
+  }
+
+  void toggleExpand(var a, var b, var c) {
+    if (busy) {
+      return;
+    }
+    busy = true;
+    var function = message['handlerFunction'];
+    var loadedFunction;
+    if (function == null) {
+      // Complete immediately.
+      loadedFunction = new Future.value(null);
+    } else {
+      loadedFunction = function.load();
+    }
+    loadedFunction.then((_) {
+      _pinned = !_pinned;
+      var messageOuter = $['messageOuter'];
+      if (_pinned) {
+        expanded = true;
+        messageOuter.classes.add('shadow');
+      } else {
+        expanded = false;
+        messageOuter.classes.remove('shadow');
+      }
+      busy = false;
+    });
+  }
+
+  Future<ServiceObject> previewMessage(_) {
+    return message.isolate.getObject(message['messageObjectId']).then((result) {
+      preview = result;
+      return result;
+    });
+  }
+}
+
 @CustomTag('debugger-console')
 class DebuggerConsoleElement extends ObservatoryElement {
   @published Isolate isolate;
 
   DebuggerConsoleElement.created() : super.created();
 
   void print(String line, { bool newline:true }) {
     var span = new SpanElement();
     span.classes.add('normal');
     span.appendText(line);
@@ skipping 86 matching lines @@
           default:
             busy = false;
             break;
         }
       });
   }
 
   DebuggerInputElement.created() : super.created();
 }