Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: ppapi/host/ppapi_host.cc

Issue 11225021: Move flash clipboard to the new proxy and add custom format support (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/host/ppapi_host.cc
diff --git a/ppapi/host/ppapi_host.cc b/ppapi/host/ppapi_host.cc
index 1361da2fe80dbb7fe62458e233513aa5ebf9dc8e..fb5d32d6afdb3f8c7ca767bff9d572b53ca494ce 100644
--- a/ppapi/host/ppapi_host.cc
+++ b/ppapi/host/ppapi_host.cc
@@ -139,6 +139,11 @@ void PpapiHost::HandleResourceCall(
// When no response is required, the message handler should not have
// written a message to be returned.
DCHECK(context->reply_msg.type() == 0);
+
+ // If there is no callback and the result of running the message handler
+ // was not PP_OK the client won't find out.
+ DLOG_IF(WARNING, reply_context.params.result() != PP_OK)
+ << "'Post' message handler failed to complete successfully.";
yzshen1 2012/10/29 16:55:46 wrong indent.
raymes 2012/10/29 18:44:58 Done.
}
} else {
reply_context.params.set_result(PP_ERROR_BADRESOURCE);

Powered by Google App Engine
This is Rietveld 408576698