content/browser/download/download_item_impl.cc - Issue 1122483004: Remove NetLog::GetCaptureMode() and NetLogCaptureMode::None()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_item_impl.cc

Issue 1122483004: Remove NetLog::GetCaptureMode() and NetLogCaptureMode::None() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mmenke_refactor

Patch Set: rename HasObservers --> IsCapturing Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/net_log_temp_file_unittest.cc ('K') | « content/browser/download/download_file_impl.cc ('k') | net/disk_cache/blockfile/entry_impl.cc » ('j') | net/log/net_log_capture_mode_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_item_impl.cc

diff --git a/content/browser/download/download_item_impl.cc b/content/browser/download/download_item_impl.cc

index be61483d4fbf28b1050e018f627c15a38ac192f1..599bc0d5ab76b5fb2d965a6cfb9cbf575168e31f 100644

--- a/content/browser/download/download_item_impl.cc

+++ b/content/browser/download/download_item_impl.cc

@@ -1055,7 +1055,7 @@ void DownloadItemImpl::DestinationUpdate(int64 bytes_so_far,

if (received_bytes_ > total_bytes_)

total_bytes_ = 0;

- if (bound_net_log_.GetCaptureMode().enabled()) {

+ if (bound_net_log_.IsCapturing()) {

bound_net_log_.AddEvent(

net::NetLog::TYPE_DOWNLOAD_ITEM_UPDATED,

net::NetLog::Int64Callback("bytes_so_far", received_bytes_));