Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Unified Diff: chrome/browser/net/net_log_temp_file_unittest.cc

Issue 1122483004: Remove NetLog::GetCaptureMode() and NetLogCaptureMode::None() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mmenke_refactor
Patch Set: rename HasObservers --> IsCapturing Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/net_log_temp_file_unittest.cc
diff --git a/chrome/browser/net/net_log_temp_file_unittest.cc b/chrome/browser/net/net_log_temp_file_unittest.cc
index 572f12ce749f00ef2eb8ea539a9a4f0f2f94f6ba..6149584e279ff5da55a0fa8cedcc66ff55333114 100644
--- a/chrome/browser/net/net_log_temp_file_unittest.cc
+++ b/chrome/browser/net/net_log_temp_file_unittest.cc
@@ -199,8 +199,6 @@ class NetLogTempFileTest : public ::testing::Test {
EXPECT_EQ(expected_log_type, net_log_temp_file_->log_type());
EXPECT_EQ(expected_log_type_string, GetLogTypeString());
mmenke 2015/05/06 15:14:41 Since you removed the check here, we have no check
eroman 2015/05/06 17:01:04 Oops my bad (I meant to add a check back for this)
- EXPECT_EQ(expected_capture_mode, net_log_->GetCaptureMode());
-
// Check GetFilePath returns false when still writing to the file.
base::FilePath net_export_file_path;
EXPECT_FALSE(net_log_temp_file_->GetFilePath(&net_export_file_path));
« no previous file with comments | « no previous file | content/browser/download/download_file_impl.cc » ('j') | net/log/net_log_capture_mode_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698