net/socket/transport_client_socket_pool.cc - Issue 1122483004: Remove NetLog::GetCaptureMode() and NetLogCaptureMode::None()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/transport_client_socket_pool.cc

Issue 1122483004: Remove NetLog::GetCaptureMode() and NetLogCaptureMode::None() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mmenke_refactor

Patch Set: second attempt at fixing int --> bool warning on windows Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/transport_client_socket_pool.cc

diff --git a/net/socket/transport_client_socket_pool.cc b/net/socket/transport_client_socket_pool.cc

index f2d124788345989d0abcdd41a83bc0e6df43b4a9..b728cb9ca03e47fec481f8c1942e7f58333c995d 100644

--- a/net/socket/transport_client_socket_pool.cc

+++ b/net/socket/transport_client_socket_pool.cc

@@ -506,7 +506,7 @@ int TransportClientSocketPool::RequestSocket(

void TransportClientSocketPool::NetLogTcpClientSocketPoolRequestedSocket(

const BoundNetLog& net_log,

const scoped_refptr<TransportSocketParams>* casted_params) {

- if (net_log.GetCaptureMode().enabled()) {

+ if (net_log.IsCapturing()) {

// TODO(eroman): Split out the host and port parameters.

net_log.AddEvent(

NetLog::TYPE_TCP_CLIENT_SOCKET_POOL_REQUESTED_SOCKET,

@@ -523,7 +523,7 @@ void TransportClientSocketPool::RequestSockets(

const scoped_refptr<TransportSocketParams>* casted_params =

static_cast<const scoped_refptr<TransportSocketParams>*>(params);

- if (net_log.GetCaptureMode().enabled()) {

+ if (net_log.IsCapturing()) {

// TODO(eroman): Split out the host and port parameters.

net_log.AddEvent(

NetLog::TYPE_TCP_CLIENT_SOCKET_POOL_REQUESTED_SOCKETS,

« no previous file with comments | « net/proxy/proxy_service.cc ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »