Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: net/log/net_log_util.cc

Issue 1122483004: Remove NetLog::GetCaptureMode() and NetLogCaptureMode::None() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mmenke_refactor
Patch Set: second attempt at fixing int --> bool warning on windows Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/log/net_log_unittest.cc ('k') | net/log/write_to_file_net_log_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/log/net_log_util.cc
diff --git a/net/log/net_log_util.cc b/net/log/net_log_util.cc
index 0ac5b4146944589b651b2e0759616c435f1f84a2..97d9a7648a746e3e4c07f08d3a59ed77d57a9ef9 100644
--- a/net/log/net_log_util.cc
+++ b/net/log/net_log_util.cc
@@ -521,10 +521,12 @@ NET_EXPORT void CreateNetLogEntriesForActiveObjects(
NetLog::ParametersCallback callback =
base::Bind(&GetRequestStateAsValue, base::Unretained(request));
+ // Note that passing the hardcoded NetLogCaptureMode::Default() below is
+ // fine, since GetRequestStateAsValue() ignores the capture mode.
NetLog::EntryData entry_data(
NetLog::TYPE_REQUEST_ALIVE, request->net_log().source(),
NetLog::PHASE_BEGIN, request->creation_time(), &callback);
- NetLog::Entry entry(&entry_data, request->net_log().GetCaptureMode());
+ NetLog::Entry entry(&entry_data, NetLogCaptureMode::Default());
observer->OnAddEntry(entry);
}
}
« no previous file with comments | « net/log/net_log_unittest.cc ('k') | net/log/write_to_file_net_log_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698