Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Side by Side Diff: net/log/net_log_util.cc

Issue 1122483004: Remove NetLog::GetCaptureMode() and NetLogCaptureMode::None() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mmenke_refactor
Patch Set: rename HasObservers --> IsCapturing Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/log/net_log_util.h" 5 #include "net/log/net_log_util.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 506 matching lines...) Expand 10 before | Expand all | Expand 10 after
517 517
518 // Create fake events. 518 // Create fake events.
519 ScopedVector<NetLog::Entry> entries; 519 ScopedVector<NetLog::Entry> entries;
520 for (const auto& request : requests) { 520 for (const auto& request : requests) {
521 NetLog::ParametersCallback callback = 521 NetLog::ParametersCallback callback =
522 base::Bind(&GetRequestStateAsValue, base::Unretained(request)); 522 base::Bind(&GetRequestStateAsValue, base::Unretained(request));
523 523
524 NetLog::EntryData entry_data( 524 NetLog::EntryData entry_data(
525 NetLog::TYPE_REQUEST_ALIVE, request->net_log().source(), 525 NetLog::TYPE_REQUEST_ALIVE, request->net_log().source(),
526 NetLog::PHASE_BEGIN, request->creation_time(), &callback); 526 NetLog::PHASE_BEGIN, request->creation_time(), &callback);
527 NetLog::Entry entry(&entry_data, request->net_log().GetCaptureMode()); 527 NetLog::Entry entry(&entry_data, NetLogCaptureMode::Default());
mmenke 2015/05/06 15:14:42 Suggest a comment that GetRequestStateAsValue igno
eroman 2015/05/06 17:01:05 Done.
528 observer->OnAddEntry(entry); 528 observer->OnAddEntry(entry);
529 } 529 }
530 } 530 }
531 531
532 } // namespace net 532 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698