LayoutTests/plugins/update-widgets-crash.html - Issue 1122483002: plugins/update-widgets-crash.html victim element goes missing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/plugins/update-widgets-crash.html

Issue 1122483002: plugins/update-widgets-crash.html victim element goes missing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/plugins/update-widgets-crash.html

diff --git a/LayoutTests/plugins/update-widgets-crash.html b/LayoutTests/plugins/update-widgets-crash.html

index 4d1fd5439da18a13bd655f85ed3e772dd6d2102a..7d9e93ea8fd4ebd4ed96a0bbd8329dbf850c844c 100644

--- a/LayoutTests/plugins/update-widgets-crash.html

+++ b/LayoutTests/plugins/update-widgets-crash.html

@@ -23,7 +23,8 @@

return;

var victim = document.getElementById('victim');

- victim.parentNode.removeChild(victim);

+ if (victim)

+ victim.parentNode.removeChild(victim);

document.body.offsetTop;

if (window.testRunner)

« no previous file with comments | « no previous file | no next file » | no next file with comments »