Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 1122483002: plugins/update-widgets-crash.html victim element goes missing (Closed)

Created:
5 years ago by Noel Gordon
Modified:
5 years ago
Reviewers:
haraken, bbudge
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

plugins/update-widgets-crash.html victim element goes missing The victim element to be removed is non-existant sometimes after the bugs listed resolved. Workaround for now, by testing that the "victim" element exists to avoid an exception, which causes extra test console output, and fails the test. See issue 476590 #46 for a bot failure example. TBR=haraken@chromium.org BUG=457054, 476590 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M LayoutTests/plugins/update-widgets-crash.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Noel Gordon
5 years ago (2015-05-01 13:37:55 UTC) #2
Noel Gordon
5 years ago (2015-05-01 13:39:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122483002/1
5 years ago (2015-05-01 13:39:24 UTC) #5
Noel Gordon
Might need if (victim && victim.parentNode) but we'll see. Can't be any more broken / ...
5 years ago (2015-05-01 13:41:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194807
5 years ago (2015-05-01 13:43:08 UTC) #7
haraken
LGTM
5 years ago (2015-05-01 13:49:11 UTC) #8
Noel Gordon
Shame it didn't quite fix it. Reverting here, and will remove the original test failure ...
5 years ago (2015-05-01 15:19:46 UTC) #9
Noel Gordon
5 years ago (2015-05-01 15:21:03 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1120963002/ by noel@chromium.org.

The reason for reverting is: Didn't quite fix the issue: same failure appeared
on the build bots.  Reverting here to fix via TestExpectations instead..

Powered by Google App Engine
This is Rietveld 408576698