Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 1122453003: Fix suppression for RemoteDOMWindow to match on release builds too. (Closed)

Created:
5 years, 7 months ago by dcheng
Modified:
5 years, 7 months ago
Reviewers:
Zhenyao Mo, earthdok
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix suppression for RemoteDOMWindow to match on release builds too. For whatever reason, symbolization is different between debug and release builds, which causes the current suppression to not match on the try bots. BUG=480676, 484760 R=zmo@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e28d513833e8084b1036af9cbc076541d3d9db62

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/sanitizers/lsan_suppressions.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
dcheng
5 years, 7 months ago (2015-05-05 17:52:07 UTC) #2
Zhenyao Mo
LGTM Can you land bypassing the try bots?
5 years, 7 months ago (2015-05-05 17:52:58 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e28d513833e8084b1036af9cbc076541d3d9db62 Cr-Commit-Position: refs/heads/master@{#328355}
5 years, 7 months ago (2015-05-05 17:56:29 UTC) #4
dcheng
5 years, 7 months ago (2015-05-05 17:56:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e28d513833e8084b1036af9cbc076541d3d9db62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698