Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: Source/core/frame/FrameView.cpp

Issue 1122453002: Revert of Put LayoutAnalyzer back behind disabled-by-default-blink.debug.layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/FrameView.h ('k') | Source/core/layout/LayoutAnalyzer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index 74e23dc96c9f96b191802d21986146f5ae768365..957f41cbf5f5c4b1a7da913de325bd673447235d 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -812,24 +812,9 @@
root.layout();
}
-void FrameView::prepareLayoutAnalyzer()
-{
- bool isTracing = false;
- TRACE_EVENT_CATEGORY_GROUP_ENABLED(TRACE_DISABLED_BY_DEFAULT("blink.debug.layout"), &isTracing);
- if (!isTracing) {
- m_analyzer.clear();
- return;
- }
- if (!m_analyzer)
- m_analyzer = adoptPtr(new LayoutAnalyzer());
- m_analyzer->reset();
-}
-
PassRefPtr<TracedValue> FrameView::analyzerCounters()
{
- if (!m_analyzer)
- return TracedValue::create();
- RefPtr<TracedValue> value = m_analyzer->toTracedValue();
+ RefPtr<TracedValue> value = layoutAnalyzer().toTracedValue();
value->setString("host", layoutView()->document().location()->host());
return value;
}
@@ -841,7 +826,7 @@
ASSERT(inSubtreeLayout || m_layoutSubtreeRoots.isEmpty());
TRACE_EVENT_BEGIN0(PERFORM_LAYOUT_TRACE_CATEGORIES, "FrameView::performLayout");
- prepareLayoutAnalyzer();
+ layoutAnalyzer().reset();
ScriptForbiddenScope forbidScript;
@@ -857,8 +842,7 @@
forceLayoutParentViewIfNeeded();
if (inSubtreeLayout) {
- if (m_analyzer)
- m_analyzer->increment(LayoutAnalyzer::PerformLayoutRootLayoutObjects, m_layoutSubtreeRoots.size());
+ layoutAnalyzer().increment(LayoutAnalyzer::PerformLayoutRootLayoutObjects, m_layoutSubtreeRoots.size());
while (m_layoutSubtreeRoots.size()) {
LayoutObject& root = *m_layoutSubtreeRoots.takeAny();
if (!root.needsLayout())
@@ -879,8 +863,7 @@
lifecycle().advanceTo(DocumentLifecycle::AfterPerformLayout);
- if (m_analyzer)
- m_analyzer->recordCounters();
+ layoutAnalyzer().recordCounters();
TRACE_EVENT_END1(PERFORM_LAYOUT_TRACE_CATEGORIES, "FrameView::performLayout",
"counters", analyzerCounters());
}
« no previous file with comments | « Source/core/frame/FrameView.h ('k') | Source/core/layout/LayoutAnalyzer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698