Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(81)

Issue 1122453002: Revert of Put LayoutAnalyzer back behind disabled-by-default-blink.debug.layout. (Closed)

Created:
5 years ago by Noel Gordon
Modified:
4 years, 12 months ago
Reviewers:
esprehn, benjhayden
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Put LayoutAnalyzer back behind disabled-by-default-blink.debug.layout. (patchset #4 id:60001 of https://codereview.chromium.org/1120833003/) Reason for revert: crbug.com/483390 Looks like this change may have caused the test on that bug to fail on all bots. A speculative revert might help resolve that. Will roll back in otherwise. BUG=483390 Original issue's description: > Put LayoutAnalyzer back behind disabled-by-default-blink.debug.layout. > > Another CL will remove the UMA. > > When the deep reports category is ready, this will move over to that. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194781 TBR=esprehn@chromium.org,benjhayden@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -33 lines) Patch
M Source/core/frame/FrameView.h View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 4 chunks +4 lines, -21 lines 0 comments Download
M Source/core/layout/LayoutAnalyzer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutAnalyzer.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Noel Gordon
Created Revert of Put LayoutAnalyzer back behind disabled-by-default-blink.debug.layout.
5 years ago (2015-05-01 08:10:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122453002/1
5 years ago (2015-05-01 08:10:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194796
5 years ago (2015-05-01 08:11:04 UTC) #3
Noel Gordon
4 years, 12 months ago (2015-05-06 08:13:42 UTC) #5
Message was sent while issue was closed.
Cane we see a LGTM here.

Powered by Google App Engine
This is Rietveld 408576698