lib/Bitcode/NaCl/Analysis/NaClBitcodeAnalyzer.cpp - Issue 1122423005: Add (unsupported experimental) feature allowing byte aligned bitcode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/Bitcode/NaCl/Analysis/NaClBitcodeAnalyzer.cpp

Issue 1122423005: Add (unsupported experimental) feature allowing byte aligned bitcode. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Patch Set: Fix nits. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« include/llvm/Bitcode/NaCl/NaClBitstreamReader.h ('K') | « include/llvm/Bitcode/NaCl/NaClBitstreamWriter.h ('k') | lib/Bitcode/NaCl/Analysis/NaClCompress.cpp » ('j') | lib/Bitcode/NaCl/Analysis/NaClCompress.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/Bitcode/NaCl/Analysis/NaClBitcodeAnalyzer.cpp

diff --git a/lib/Bitcode/NaCl/Analysis/NaClBitcodeAnalyzer.cpp b/lib/Bitcode/NaCl/Analysis/NaClBitcodeAnalyzer.cpp

index 3caab42e06d3067c258825071119ab50a6c9da48..b987125a2389334bad2c4696a758ae4529ad91cc 100644

--- a/lib/Bitcode/NaCl/Analysis/NaClBitcodeAnalyzer.cpp

+++ b/lib/Bitcode/NaCl/Analysis/NaClBitcodeAnalyzer.cpp

@@ -408,9 +408,10 @@ int AnalyzeBitcodeInBuffer(const std::unique_ptr<MemoryBuffer> &Buf,

const unsigned char *BufPtr = (const unsigned char *)Buf->getBufferStart();

const unsigned char *EndBufPtr = BufPtr + Buf->getBufferSize();

+ const unsigned char *HeaderPtr = BufPtr;

NaClBitcodeHeader Header;

- if (Header.Read(BufPtr, EndBufPtr))

+ if (Header.Read(HeaderPtr, EndBufPtr))

return Error("Invalid PNaCl bitcode header");

if (!Header.IsSupported())

@@ -419,7 +420,7 @@ int AnalyzeBitcodeInBuffer(const std::unique_ptr<MemoryBuffer> &Buf,

if (!Header.IsReadable())

Error("Bitcode file is not readable");

- NaClBitstreamReader StreamFile(BufPtr, EndBufPtr);

+ NaClBitstreamReader StreamFile(BufPtr, EndBufPtr, Header);

NaClBitstreamCursor Stream(StreamFile);

unsigned NumTopBlocks = 0;