[turbofan] Add support for advanced reducers.

src/compiler/graph-reducer.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <functional>
 
 #include "src/compiler/graph.h"
 #include "src/compiler/graph-reducer.h"
 #include "src/compiler/node.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
+bool Reducer::Finish() { return true; }
+
+
 enum class GraphReducer::State : uint8_t {
   kUnvisited,
   kRevisit,
   kOnStack,
   kVisited
 };
 
 
 GraphReducer::GraphReducer(Graph* graph, Zone* zone)
     : graph_(graph),
       state_(graph, 4),
       reducers_(zone),
       revisit_(zone),
       stack_(zone) {}
 
 
+GraphReducer::~GraphReducer() {}
+
+
 void GraphReducer::AddReducer(Reducer* reducer) {
   reducers_.push_back(reducer);
 }
 
 
 void GraphReducer::ReduceNode(Node* node) {
   DCHECK(stack_.empty());
   DCHECK(revisit_.empty());
   Push(node);
   for (;;) {
@@ skipping 11 matching lines @@
       }
     } else {
       break;
     }
   }
   DCHECK(revisit_.empty());
   DCHECK(stack_.empty());
 }
 
 
-void GraphReducer::ReduceGraph() { ReduceNode(graph()->end()); }
+void GraphReducer::ReduceGraph() {
+  for (;;) {
+    ReduceNode(graph()->end());
+    if (Finish()) break;
+    // Reset all marks on the graph in preparation to re-reduce the graph.
+    state_.Reset(graph());
+  }
+}
 
 
 Reduction GraphReducer::Reduce(Node* const node) {
   auto skip = reducers_.end();
   for (auto i = reducers_.begin(); i != reducers_.end();) {
     if (i != skip) {
       Reduction reduction = (*i)->Reduce(node);
       if (!reduction.Changed()) {
         // No change from this reducer.
       } else if (reduction.replacement() == node) {
@@ skipping 55 matching lines @@
     for (int i = 0; i < node->InputCount(); ++i) {
       Node* input = node->InputAt(i);
       entry.input_index = i + 1;
       if (input != node && Recurse(input)) return;
     }
   }
 
   // After reducing the node, pop it off the stack.
   Pop();
 
-  // Revisit all uses of the node.
-  for (Node* const use : node->uses()) {
-    // Don't revisit this node if it refers to itself.
-    if (use != node) Revisit(use);
-  }
-
   // Check if we have a new replacement.
   if (replacement != node) {
-    if (node == graph()->start()) graph()->SetStart(replacement);
-    if (node == graph()->end()) graph()->SetEnd(replacement);
     // If {node} was replaced by an old node, unlink {node} and assume that
     // {replacement} was already reduced and finish.
     if (replacement->id() < node_count) {
-      node->ReplaceUses(replacement);
-      node->Kill();
+      Replace(node, replacement);
     } else {
       // Otherwise {node} was replaced by a new node. Replace all old uses of
       // {node} with {replacement}. New nodes created by this reduction can
       // use {node}.
+      if (node == graph()->start()) graph()->SetStart(replacement);
+      if (node == graph()->end()) graph()->SetEnd(replacement);
       for (Edge edge : node->use_edges()) {
-        if (edge.from()->id() < node_count) {
+        Node* const user = edge.from();
+        if (user->id() < node_count) {
           edge.UpdateTo(replacement);
+          // Don't revisit this node if it refers to itself.
+          if (user != node) Revisit(user);
         }
       }
       // Unlink {node} if it's no longer used.
-      if (node->uses().empty()) {
-        node->Kill();
-      }
+      if (node->uses().empty()) node->Kill();
 
       // If there was a replacement, reduce it after popping {node}.
       Recurse(replacement);
     }
+  } else {
+    // Revisit all uses of the node.
+    for (Node* const user : node->uses()) {
+      // Don't revisit this node if it refers to itself.
+      if (user != node) Revisit(user);
+    }
   }
 }
 
 
+void GraphReducer::Replace(Node* node, Node* replacement) {

[titzer, 2015/05/06 09:22:08]

I prefer the simplification in my other CL which made this into one method.

[Benedikt Meurer, 2015/05/06 09:33:30]

Done.

+  if (node == graph()->start()) graph()->SetStart(replacement);
+  if (node == graph()->end()) graph()->SetEnd(replacement);
+  for (Edge edge : node->use_edges()) {
+    Node* const user = edge.from();
+    edge.UpdateTo(replacement);
+    // Don't revisit this node if it refers to itself.
+    if (user != node) Revisit(user);
+  }
+  node->Kill();
+}
+
+
 void GraphReducer::Pop() {
   Node* node = stack_.top().node;
   state_.Set(node, State::kVisited);
   stack_.pop();
 }
 
 
 void GraphReducer::Push(Node* const node) {
   DCHECK(state_.Get(node) != State::kOnStack);
   state_.Set(node, State::kOnStack);
@@ skipping 11 matching lines @@
 void GraphReducer::Revisit(Node* node) {
   if (state_.Get(node) == State::kVisited) {
     state_.Set(node, State::kRevisit);
     revisit_.push(node);
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8