Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1122403004: Fix Python error in build-webapp.py:parseBool() (Closed)

Created:
5 years, 7 months ago by Lambros
Modified:
5 years, 7 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Python error in build-webapp.py:parseBool() Problem only repros when trying to build with XMPP_SERVER_USE_TLS=[anything], which is probably why this went unnoticed. Committed: https://crrev.com/85b72195abaf3d2f2f5b46abe36fd8179fbb3a99 Cr-Commit-Position: refs/heads/master@{#329165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/webapp/build-webapp.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Lambros
5 years, 7 months ago (2015-05-08 23:08:22 UTC) #2
garykac
lgtm
5 years, 7 months ago (2015-05-08 23:20:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122403004/1
5 years, 7 months ago (2015-05-08 23:30:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on ...
5 years, 7 months ago (2015-05-09 03:51:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122403004/1
5 years, 7 months ago (2015-05-11 16:15:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 17:06:48 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 17:07:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85b72195abaf3d2f2f5b46abe36fd8179fbb3a99
Cr-Commit-Position: refs/heads/master@{#329165}

Powered by Google App Engine
This is Rietveld 408576698