Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 1122393005: [Media Router] Reland of "Media Router GYP/GN cleanup". (Closed)

Created:
5 years, 7 months ago by imcheng (use chromium acct)
Modified:
5 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, chromium-apps-reviews_chromium.org, wjia+watch_chromium.org, mark a. foltz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Reland of "Media Router GYP/GN cleanup". Removed extra 'dependency' on target 'media_router_test_support'. Also removed the ':' on some local dependencies. Original patch: https://codereview.chromium.org/1136623003/ Original patch description: - Refactor GYP and GN files to share source lists. - Extract a proper test_support target. - Fix upstream files with new target structure. BUG=461815, 464199, 464205 TEST=Linux trybots. It's not clear to be exactly which bot, since original patch failed after getting through trybots/CQ. Committed: https://crrev.com/b6b09239feb034d546976028a15c75404579d0bb Cr-Commit-Position: refs/heads/master@{#330204}

Patch Set 1 : original patch #

Patch Set 2 : Fix #

Patch Set 3 : merge sources into chrome_unit_tests_media_router_sources #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -170 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/media/router/BUILD.gn View 2 chunks +20 lines, -78 lines 0 comments Download
M chrome/browser/media/router/media_router.gyp View 1 4 chunks +15 lines, -39 lines 0 comments Download
A chrome/browser/media/router/media_router.gypi View 1 chunk +44 lines, -0 lines 0 comments Download
D chrome/browser/media/router/media_router_tests.gypi View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 chunks +18 lines, -5 lines 0 comments Download
M chrome/common/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/test/BUILD.gn View 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
imcheng (use chromium acct)
PTAL, thanks.
5 years, 7 months ago (2015-05-15 19:06:19 UTC) #2
brettw
lgtm rubberstamp
5 years, 7 months ago (2015-05-15 21:24:15 UTC) #3
imcheng (use chromium acct)
Thanks Brett, submitting. +mfoltz as FYI.
5 years, 7 months ago (2015-05-15 21:32:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122393005/40001
5 years, 7 months ago (2015-05-15 21:35:18 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-15 21:42:03 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:27:52 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b6b09239feb034d546976028a15c75404579d0bb
Cr-Commit-Position: refs/heads/master@{#330204}

Powered by Google App Engine
This is Rietveld 408576698