media/audio/clockless_audio_sink.cc - Issue 1122393004: Add support for switching the audio output device for HTMLMediaElements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/clockless_audio_sink.cc

Issue 1122393004: Add support for switching the audio output device for HTMLMediaElements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes to MediaPlayers so that they invoke callbacks in the correct threads. First complete implem… Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/audio/clockless_audio_sink.cc

diff --git a/media/audio/clockless_audio_sink.cc b/media/audio/clockless_audio_sink.cc

index 77f7057119a1b424da9c7945db5af1225dbde430..c44fd780dd77b32badde5f4a2303467ade1c8465 100644

--- a/media/audio/clockless_audio_sink.cc

+++ b/media/audio/clockless_audio_sink.cc

@@ -107,4 +107,9 @@ bool ClocklessAudioSink::SetVolume(double volume) {

return volume == 0.0;

}

+void ClocklessAudioSink::SwitchOutputDevice(

+ const std::string& device_id,

+ const GURL& security_origin,

+ const base::Callback<void(int)>& callback) { }

miu 2015/06/03 21:01:01 ditto: Run the callback with a failure code here.

} // namespace media

« media/audio/audio_output_stream_sink.cc ('K') | « media/audio/clockless_audio_sink.h ('k') | media/audio/fake_audio_log_factory.cc » ('j') | media/audio/null_audio_sink.cc » ('J')