Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: cc/layers/surface_layer_unittest.cc

Issue 1122393003: CC: Plumb LayerSettings parameter for cc::Layer construction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/layers/surface_layer.cc ('k') | cc/layers/texture_layer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <set> 5 #include <set>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "base/thread_task_runner_handle.h" 10 #include "base/thread_task_runner_handle.h"
(...skipping 28 matching lines...) Expand all
39 void TearDown() override { 39 void TearDown() override {
40 if (layer_tree_host_) { 40 if (layer_tree_host_) {
41 layer_tree_host_->SetRootLayer(nullptr); 41 layer_tree_host_->SetRootLayer(nullptr);
42 layer_tree_host_ = nullptr; 42 layer_tree_host_ = nullptr;
43 } 43 }
44 } 44 }
45 45
46 scoped_ptr<FakeLayerTreeHost> layer_tree_host_; 46 scoped_ptr<FakeLayerTreeHost> layer_tree_host_;
47 FakeLayerTreeHostClient fake_client_; 47 FakeLayerTreeHostClient fake_client_;
48 TestSharedBitmapManager shared_bitmap_manager_; 48 TestSharedBitmapManager shared_bitmap_manager_;
49 LayerSettings layer_settings_;
49 }; 50 };
50 51
51 void SatisfyCallback(SurfaceSequence* out, SurfaceSequence in) { 52 void SatisfyCallback(SurfaceSequence* out, SurfaceSequence in) {
52 *out = in; 53 *out = in;
53 } 54 }
54 55
55 void RequireCallback(SurfaceId* out_id, 56 void RequireCallback(SurfaceId* out_id,
56 std::set<SurfaceSequence>* out, 57 std::set<SurfaceSequence>* out,
57 SurfaceId in_id, 58 SurfaceId in_id,
58 SurfaceSequence in) { 59 SurfaceSequence in) {
59 *out_id = in_id; 60 *out_id = in_id;
60 out->insert(in); 61 out->insert(in);
61 } 62 }
62 63
63 // Check that one surface can be referenced by multiple LayerTreeHosts, and 64 // Check that one surface can be referenced by multiple LayerTreeHosts, and
64 // each will create its own SurfaceSequence that's satisfied on destruction. 65 // each will create its own SurfaceSequence that's satisfied on destruction.
65 TEST_F(SurfaceLayerTest, MultipleFramesOneSurface) { 66 TEST_F(SurfaceLayerTest, MultipleFramesOneSurface) {
66 SurfaceSequence blank_change; // Receives sequence if commit doesn't happen. 67 SurfaceSequence blank_change; // Receives sequence if commit doesn't happen.
67 68
68 SurfaceId required_id; 69 SurfaceId required_id;
69 std::set<SurfaceSequence> required_seq; 70 std::set<SurfaceSequence> required_seq;
70 scoped_refptr<SurfaceLayer> layer(SurfaceLayer::Create( 71 scoped_refptr<SurfaceLayer> layer(SurfaceLayer::Create(
71 base::Bind(&SatisfyCallback, &blank_change), 72 layer_settings_, base::Bind(&SatisfyCallback, &blank_change),
72 base::Bind(&RequireCallback, &required_id, &required_seq))); 73 base::Bind(&RequireCallback, &required_id, &required_seq)));
73 layer->SetSurfaceId(SurfaceId(1), 1.f, gfx::Size(1, 1)); 74 layer->SetSurfaceId(SurfaceId(1), 1.f, gfx::Size(1, 1));
74 layer_tree_host_->set_surface_id_namespace(1); 75 layer_tree_host_->set_surface_id_namespace(1);
75 layer_tree_host_->SetRootLayer(layer); 76 layer_tree_host_->SetRootLayer(layer);
76 77
77 scoped_ptr<FakeLayerTreeHost> layer_tree_host2 = 78 scoped_ptr<FakeLayerTreeHost> layer_tree_host2 =
78 FakeLayerTreeHost::Create(&fake_client_); 79 FakeLayerTreeHost::Create(&fake_client_);
79 scoped_refptr<SurfaceLayer> layer2(SurfaceLayer::Create( 80 scoped_refptr<SurfaceLayer> layer2(SurfaceLayer::Create(
80 base::Bind(&SatisfyCallback, &blank_change), 81 layer_settings_, base::Bind(&SatisfyCallback, &blank_change),
81 base::Bind(&RequireCallback, &required_id, &required_seq))); 82 base::Bind(&RequireCallback, &required_id, &required_seq)));
82 layer2->SetSurfaceId(SurfaceId(1), 1.f, gfx::Size(1, 1)); 83 layer2->SetSurfaceId(SurfaceId(1), 1.f, gfx::Size(1, 1));
83 layer_tree_host2->set_surface_id_namespace(2); 84 layer_tree_host2->set_surface_id_namespace(2);
84 layer_tree_host2->SetRootLayer(layer2); 85 layer_tree_host2->SetRootLayer(layer2);
85 86
86 // Layers haven't been removed, so no sequence should be satisfied. 87 // Layers haven't been removed, so no sequence should be satisfied.
87 EXPECT_TRUE(blank_change.is_null()); 88 EXPECT_TRUE(blank_change.is_null());
88 89
89 SurfaceSequence expected1(1u, 1u); 90 SurfaceSequence expected1(1u, 1u);
90 SurfaceSequence expected2(2u, 1u); 91 SurfaceSequence expected2(2u, 1u);
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 inputs.device_scale_factor = device_scale_factor; 123 inputs.device_scale_factor = device_scale_factor;
123 LayerTreeHostCommon::CalculateDrawProperties(&inputs); 124 LayerTreeHostCommon::CalculateDrawProperties(&inputs);
124 } 125 }
125 126
126 // Check that setting content scale on the surface works. 127 // Check that setting content scale on the surface works.
127 TEST_F(SurfaceLayerTest, ScaleSurface) { 128 TEST_F(SurfaceLayerTest, ScaleSurface) {
128 SurfaceSequence blank_change; 129 SurfaceSequence blank_change;
129 SurfaceId required_id; 130 SurfaceId required_id;
130 std::set<SurfaceSequence> required_seq; 131 std::set<SurfaceSequence> required_seq;
131 scoped_refptr<SurfaceLayer> layer(SurfaceLayer::Create( 132 scoped_refptr<SurfaceLayer> layer(SurfaceLayer::Create(
132 base::Bind(&SatisfyCallback, &blank_change), 133 layer_settings_, base::Bind(&SatisfyCallback, &blank_change),
133 base::Bind(&RequireCallback, &required_id, &required_seq))); 134 base::Bind(&RequireCallback, &required_id, &required_seq)));
134 gfx::Size surface_size(10, 15); 135 gfx::Size surface_size(10, 15);
135 layer->SetSurfaceId(SurfaceId(1), 2.f, surface_size); 136 layer->SetSurfaceId(SurfaceId(1), 2.f, surface_size);
136 layer->SetBounds(gfx::Size(25, 45)); 137 layer->SetBounds(gfx::Size(25, 45));
137 layer_tree_host_->SetRootLayer(layer); 138 layer_tree_host_->SetRootLayer(layer);
138 139
139 CalcDrawProps(layer_tree_host_.get(), 5.f); 140 CalcDrawProps(layer_tree_host_.get(), 5.f);
140 EXPECT_EQ(2.f, layer->contents_scale_x()); 141 EXPECT_EQ(2.f, layer->contents_scale_x());
141 EXPECT_EQ(2.f, layer->contents_scale_y()); 142 EXPECT_EQ(2.f, layer->contents_scale_y());
142 EXPECT_EQ(surface_size.ToString(), layer->content_bounds().ToString()); 143 EXPECT_EQ(surface_size.ToString(), layer->content_bounds().ToString());
143 144
144 layer_tree_host_->SetRootLayer(nullptr); 145 layer_tree_host_->SetRootLayer(nullptr);
145 layer_tree_host_.reset(); 146 layer_tree_host_.reset();
146 } 147 }
147 148
148 // Check that SurfaceSequence is sent through swap promise. 149 // Check that SurfaceSequence is sent through swap promise.
149 class SurfaceLayerSwapPromise : public LayerTreeTest { 150 class SurfaceLayerSwapPromise : public LayerTreeTest {
150 public: 151 public:
151 SurfaceLayerSwapPromise() 152 SurfaceLayerSwapPromise()
152 : commit_count_(0), sequence_was_satisfied_(false) {} 153 : commit_count_(0), sequence_was_satisfied_(false) {}
153 154
154 void BeginTest() override { 155 void BeginTest() override {
155 layer_tree_host()->set_surface_id_namespace(1); 156 layer_tree_host()->set_surface_id_namespace(1);
156 layer_ = SurfaceLayer::Create( 157 layer_ = SurfaceLayer::Create(
157 base::Bind(&SatisfyCallback, &satisfied_sequence_), 158 layer_settings(), base::Bind(&SatisfyCallback, &satisfied_sequence_),
158 base::Bind(&RequireCallback, &required_id_, &required_set_)); 159 base::Bind(&RequireCallback, &required_id_, &required_set_));
159 layer_->SetSurfaceId(SurfaceId(1), 1.f, gfx::Size(1, 1)); 160 layer_->SetSurfaceId(SurfaceId(1), 1.f, gfx::Size(1, 1));
160 161
161 // Layer hasn't been added to tree so no SurfaceSequence generated yet. 162 // Layer hasn't been added to tree so no SurfaceSequence generated yet.
162 EXPECT_EQ(0u, required_set_.size()); 163 EXPECT_EQ(0u, required_set_.size());
163 164
164 layer_tree_host()->SetRootLayer(layer_); 165 layer_tree_host()->SetRootLayer(layer_);
165 166
166 // Should have SurfaceSequence from first tree. 167 // Should have SurfaceSequence from first tree.
167 SurfaceSequence expected(1u, 1u); 168 SurfaceSequence expected(1u, 1u);
(...skipping 10 matching lines...) Expand all
178 base::ThreadTaskRunnerHandle::Get()->PostTask( 179 base::ThreadTaskRunnerHandle::Get()->PostTask(
179 FROM_HERE, base::Bind(&SurfaceLayerSwapPromise::ChangeTree, 180 FROM_HERE, base::Bind(&SurfaceLayerSwapPromise::ChangeTree,
180 base::Unretained(this))); 181 base::Unretained(this)));
181 } 182 }
182 183
183 void ChangeTree() { 184 void ChangeTree() {
184 ++commit_count_; 185 ++commit_count_;
185 switch (commit_count_) { 186 switch (commit_count_) {
186 case 1: 187 case 1:
187 // Remove SurfaceLayer from tree to cause SwapPromise to be created. 188 // Remove SurfaceLayer from tree to cause SwapPromise to be created.
188 blank_layer_ = SolidColorLayer::Create(); 189 blank_layer_ = SolidColorLayer::Create(layer_settings());
189 blank_layer_->SetIsDrawable(true); 190 blank_layer_->SetIsDrawable(true);
190 blank_layer_->SetBounds(gfx::Size(10, 10)); 191 blank_layer_->SetBounds(gfx::Size(10, 10));
191 layer_tree_host()->SetRootLayer(blank_layer_); 192 layer_tree_host()->SetRootLayer(blank_layer_);
192 break; 193 break;
193 case 2: 194 case 2:
194 break; 195 break;
195 default: 196 default:
196 NOTREACHED(); 197 NOTREACHED();
197 break; 198 break;
198 } 199 }
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 SurfaceId required_id_; 233 SurfaceId required_id_;
233 std::set<SurfaceSequence> required_set_; 234 std::set<SurfaceSequence> required_set_;
234 }; 235 };
235 236
236 // TODO(jbauman): Reenable on single thread once http://crbug.com/421923 is 237 // TODO(jbauman): Reenable on single thread once http://crbug.com/421923 is
237 // fixed. 238 // fixed.
238 MULTI_THREAD_TEST_F(SurfaceLayerSwapPromise); 239 MULTI_THREAD_TEST_F(SurfaceLayerSwapPromise);
239 240
240 } // namespace 241 } // namespace
241 } // namespace cc 242 } // namespace cc
OLDNEW
« no previous file with comments | « cc/layers/surface_layer.cc ('k') | cc/layers/texture_layer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698