CC: Plumb LayerSettings parameter for cc::Layer construction.

cc/trees/layer_tree_settings.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_settings.h"
 
 #include <GLES2/gl2.h>
 #include <limits>
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 
 namespace cc {
 
+LayerSettings::LayerSettings() : use_compositor_animation_timelines(false) {

[enne (OOO), 2015/05/18 21:49:49]

Are you expecting more settings in the future? Does this bool have to be a ctor
parameter to Layer?

[loyso (OOO), 2015/05/19 01:03:44]

A bit of context/historical background: It's started here
https://codereview.chromium.org/1101823002/patch/120001/130002

Strictly IMHO:

1) No, I don't expect more settings in the future, especially in the context of
my project (cc animations). cc::Layer constructor will be eventually empty:
https://codereview.chromium.org/1130043003/diff/20001/cc/layers/layer.cc

Moreover, in a long term cc::Layers system is deprecated in favor of
DisplayLists (Slimming Paint).

2) No, that bool hasn't to be passed intro constructor if we choose
RegisterForAnimations approach. (Patch Set#7
https://codereview.chromium.org/1101823002/#ps120001)

+}
+
+LayerSettings::~LayerSettings() {
+}
+
 LayerTreeSettings::LayerTreeSettings()
     : impl_side_painting(false),
       raster_enabled(true),
       throttle_frame_production(true),
       single_thread_proxy_scheduler(true),
       use_external_begin_frame_source(false),
       main_frame_before_activation_enabled(false),
       using_synchronous_renderer_compositor(false),
       report_overscroll_only_for_scrollable_axes(false),
       per_tile_painting_enabled(false),
@@ skipping 36 matching lines @@
       use_zero_copy(false),
       enable_elastic_overscroll(false),
       use_image_texture_target(GL_TEXTURE_2D),
       ignore_root_layer_flings(false),
       scheduled_raster_task_limit(32),
       use_occlusion_for_tile_prioritization(false),
       record_full_layer(false),
       use_display_lists(false),
       use_cached_picture_in_display_list(true),
       verify_property_trees(false),
-      gather_pixel_refs(false),
-      use_compositor_animation_timelines(false) {
+      gather_pixel_refs(false) {
 }
 
 LayerTreeSettings::~LayerTreeSettings() {}
 
 SchedulerSettings LayerTreeSettings::ToSchedulerSettings() const {
   SchedulerSettings scheduler_settings;
   scheduler_settings.use_external_begin_frame_source =
       use_external_begin_frame_source;
   scheduler_settings.main_frame_before_activation_enabled =
       main_frame_before_activation_enabled;
   scheduler_settings.impl_side_painting = impl_side_painting;
   scheduler_settings.timeout_and_draw_when_animation_checkerboards =
       timeout_and_draw_when_animation_checkerboards;
   scheduler_settings.maximum_number_of_failed_draws_before_draw_is_forced_ =
       maximum_number_of_failed_draws_before_draw_is_forced_;
   scheduler_settings.using_synchronous_renderer_compositor =
       using_synchronous_renderer_compositor;
   scheduler_settings.throttle_frame_production = throttle_frame_production;
   scheduler_settings.main_thread_should_always_be_low_latency = false;
   scheduler_settings.background_frame_interval =
       base::TimeDelta::FromSecondsD(1.0 / background_animation_rate);
   return scheduler_settings;
 }
 
 }  // namespace cc