Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1122373004: [Sync] Test signing in and back out on Android (Closed)

Created:
5 years, 7 months ago by maxbogue
Modified:
5 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Test signing in and back out on Android Ensure that sync still starts properly after signing out and back in. BUG=480604 Committed: https://crrev.com/c9e3a7c2e3e4ffb527923b45b2ed592bb812ea42 Cr-Commit-Position: refs/heads/master@{#330224}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -10 lines) Patch
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 1 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java View 1 4 chunks +20 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
maxbogue
Hey Nick, it's another test! Please take a look :) +Patrick to confirm that I'm ...
5 years, 7 months ago (2015-05-15 02:12:26 UTC) #2
maniscalco
LGTM
5 years, 7 months ago (2015-05-15 17:23:01 UTC) #3
pval...(no longer on Chromium)
lgtm IIRC, the method call is extraneous because I think the web page gets loaded ...
5 years, 7 months ago (2015-05-15 17:54:47 UTC) #4
maxbogue
+Nicolas for owners
5 years, 7 months ago (2015-05-15 18:21:22 UTC) #6
Nicolas Zea
lgtm
5 years, 7 months ago (2015-05-15 20:11:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122373004/20001
5 years, 7 months ago (2015-05-15 22:57:47 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 23:09:20 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:28:47 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c9e3a7c2e3e4ffb527923b45b2ed592bb812ea42
Cr-Commit-Position: refs/heads/master@{#330224}

Powered by Google App Engine
This is Rietveld 408576698