Issue 1122343002: Clean up //services/BUILD.gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1122343002: Clean up //services/BUILD.gn. (Closed)

Created:
5 years, 7 months ago by viettrungluu

Modified:
5 years, 7 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Clean up //services/BUILD.gn. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0d86dc8b8b04258c1d42cfdf5d9b6bc410a8f0e7

Patch Set 2 : abs #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	services/BUILD.gn	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jamesr

https://codereview.chromium.org/1122343002/diff/1/services/BUILD.gn File services/BUILD.gn (right): https://codereview.chromium.org/1122343002/diff/1/services/BUILD.gn#newcode7 services/BUILD.gn:7: "clipboard", I think we should keep these DEPS relative ...

5 years, 7 months ago (2015-05-05 21:49:52 UTC) #2

viettrungluu

Committed patchset #2 (id:20001) manually as 0d86dc8b8b04258c1d42cfdf5d9b6bc410a8f0e7 (presubmit successful).

5 years, 7 months ago (2015-05-05 22:27:01 UTC) #3

viettrungluu

5 years, 7 months ago (2015-05-05 22:27:24 UTC) #4

Message was sent while issue was closed.

On 2015/05/05 21:49:52, jamesr wrote:
> https://codereview.chromium.org/1122343002/diff/1/services/BUILD.gn
> File services/BUILD.gn (right):
> 
> https://codereview.chromium.org/1122343002/diff/1/services/BUILD.gn#newcode7
> services/BUILD.gn:7: "clipboard",
> I think we should keep these DEPS relative to the root, i.e.
> 
> //services/clipboard
> 
> since ":clipboard" vs "clipboard" is pretty subtle and there's no need to have
> this file be relocatable

OK, fair enough. (I guess we also use absolute includes in C++....)

> 
> otherwise lgtm

Expand Messages | Collapse Messages

Issue 1122343002: Clean up //services/BUILD.gn. (Closed)

Description

Patch Set 1 #

Patch Set 2 : abs #

Messages