Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: Source/core/layout/LayoutFlowThread.h

Issue 1122323002: Cleanup: Remove LayoutRegion. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase master Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/LayoutBoxModelObject.cpp ('k') | Source/core/layout/LayoutFlowThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutFlowThread.h
diff --git a/Source/core/layout/LayoutFlowThread.h b/Source/core/layout/LayoutFlowThread.h
index 4d7f9c6a4933dee9664ebc9bbdb335b1d6ff9f16..4f4c8392b4f001fd139239624c66607f1a443cdd 100644
--- a/Source/core/layout/LayoutFlowThread.h
+++ b/Source/core/layout/LayoutFlowThread.h
@@ -38,16 +38,13 @@
namespace blink {
class LayoutMultiColumnSet;
-class LayoutRegion;
typedef ListHashSet<LayoutMultiColumnSet*> LayoutMultiColumnSetList;
-// LayoutFlowThread is used to collect all the layout objects that participate in a
-// flow thread. It will also help in doing the layout. However, it will not layout
-// directly to screen. Instead, LayoutRegion objects will redirect their paint
-// and nodeAtPoint methods to this object. Each LayoutRegion will actually be a viewPort
-// of the LayoutFlowThread.
-
+// LayoutFlowThread is used to collect all the layout objects that participate in a flow thread. It
+// will also help in doing the layout. However, it will not layout directly to screen. Instead,
+// LayoutMultiColumnSet objects will redirect their paint and nodeAtPoint methods to this
+// object. Each LayoutMultiColumnSet will actually be a viewPort of the LayoutFlowThread.
class CORE_EXPORT LayoutFlowThread: public LayoutBlockFlow {
public:
LayoutFlowThread();
@@ -77,16 +74,16 @@ public:
virtual bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) override final;
- virtual void addRegionToThread(LayoutMultiColumnSet*) = 0;
- virtual void removeRegionFromThread(LayoutMultiColumnSet*);
+ virtual void addColumnSetToThread(LayoutMultiColumnSet*) = 0;
+ virtual void removeColumnSetFromThread(LayoutMultiColumnSet*);
virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, LogicalExtentComputedValues&) const override;
- bool hasRegions() const { return m_multiColumnSetList.size(); }
+ bool hasColumnSets() const { return m_multiColumnSetList.size(); }
- void validateRegions();
- void invalidateRegions();
- bool hasValidRegionInfo() const { return !m_regionsInvalidated && !m_multiColumnSetList.isEmpty(); }
+ void validateColumnSets();
+ void invalidateColumnSets();
+ bool hasValidColumnSetInfo() const { return !m_columnSetsInvalidated && !m_multiColumnSetList.isEmpty(); }
virtual void mapRectToPaintInvalidationBacking(const LayoutBoxModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalidationState*) const override;
@@ -96,13 +93,9 @@ public:
virtual void setPageBreak(LayoutUnit /*offset*/, LayoutUnit /*spaceShortage*/) { }
virtual void updateMinimumPageHeight(LayoutUnit /*offset*/, LayoutUnit /*minHeight*/) { }
- bool regionsHaveUniformLogicalHeight() const { return m_regionsHaveUniformLogicalHeight; }
-
- // FIXME: These 2 functions should return a LayoutMultiColumnSet.
- LayoutRegion* firstRegion() const;
- LayoutRegion* lastRegion() const;
+ bool columnSetsHaveUniformLogicalHeight() const { return m_columnSetsHaveUniformLogicalHeight; }
- virtual bool addForcedRegionBreak(LayoutUnit, LayoutObject* breakChild, bool isBefore, LayoutUnit* offsetBreakAdjustment = 0) { return false; }
+ virtual bool addForcedColumnBreak(LayoutUnit, LayoutObject* breakChild, bool isBefore, LayoutUnit* offsetBreakAdjustment = 0) { return false; }
virtual bool isPageLogicalHeightKnown() const { return true; }
bool pageLogicalSizeChanged() const { return m_pageLogicalSizeChanged; }
@@ -156,8 +149,8 @@ protected:
MultiColumnSetIntervalTree m_multiColumnSetIntervalTree;
- bool m_regionsInvalidated : 1;
- bool m_regionsHaveUniformLogicalHeight : 1;
+ bool m_columnSetsInvalidated : 1;
+ bool m_columnSetsHaveUniformLogicalHeight : 1;
bool m_pageLogicalSizeChanged : 1;
};
« no previous file with comments | « Source/core/layout/LayoutBoxModelObject.cpp ('k') | Source/core/layout/LayoutFlowThread.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698