Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Side by Side Diff: test/checker/checker_test.dart

Issue 1122313002: Typing fixes to eliminate casts/dcalls (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/src/checker/rules.dart ('k') | test/dart_codegen/expect/async/stream.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /// General type checking tests 5 /// General type checking tests
6 library dev_compiler.test.checker_test; 6 library dev_compiler.test.checker_test;
7 7
8 import 'package:unittest/unittest.dart'; 8 import 'package:unittest/unittest.dart';
9 9
10 import 'package:dev_compiler/src/testing.dart'; 10 import 'package:dev_compiler/src/testing.dart';
(...skipping 19 matching lines...) Expand all
30 _Predicate _validKey; 30 _Predicate _validKey;
31 31
32 // Initializing _comparator needs a cast, since K may not always be 32 // Initializing _comparator needs a cast, since K may not always be
33 // Comparable. 33 // Comparable.
34 // Initializing _validKey shouldn't need a cast. Currently 34 // Initializing _validKey shouldn't need a cast. Currently
35 // it requires inference to work because of dartbug.com/23381 35 // it requires inference to work because of dartbug.com/23381
36 SplayTreeMap([int compare(K key1, K key2), 36 SplayTreeMap([int compare(K key1, K key2),
37 bool isValidKey(potentialKey)]) { 37 bool isValidKey(potentialKey)]) {
38 : _comparator = /*warning:DownCastComposite*/(compare == null) ? Com parable.compare : compare, 38 : _comparator = /*warning:DownCastComposite*/(compare == null) ? Com parable.compare : compare,
39 _validKey = /*info:InferredType should be pass*/(isValidKey != nul l) ? isValidKey : ((v) => true); 39 _validKey = /*info:InferredType should be pass*/(isValidKey != nul l) ? isValidKey : ((v) => true);
40 _Predicate<Object> _v = /*warning:DownCastComposite*/(isValidKey ! = null) ? isValidKey : ((v) => true);
41 _v = /*info:InferredType should be pass*/(isValidKey != null) ? _v : ((v) => true);
40 } 42 }
41 } 43 }
42 void main() { 44 void main() {
43 } 45 }
44 ''' 46 '''
45 }); 47 });
46 }); 48 });
47 49
48 test('dynamic invocation', () { 50 test('dynamic invocation', () {
49 testChecker({ 51 testChecker({
(...skipping 2863 matching lines...) Expand 10 before | Expand all | Expand 10 after
2913 f = bar as II2D; 2915 f = bar as II2D;
2914 f = bar as DD2I; 2916 f = bar as DD2I;
2915 f = bar as DI2D; 2917 f = bar as DI2D;
2916 f = bar as ID2D; 2918 f = bar as ID2D;
2917 f = bar as DD2D; 2919 f = bar as DD2D;
2918 } 2920 }
2919 ''' 2921 '''
2920 }); 2922 });
2921 }); 2923 });
2922 } 2924 }
OLDNEW
« no previous file with comments | « lib/src/checker/rules.dart ('k') | test/dart_codegen/expect/async/stream.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698