Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 11223003: Remove unneeded command line args from VS addin examples. (Closed)

Created:
8 years, 4 months ago by Sam Clegg
Modified:
8 years, 4 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Remove unneeded command line args from VS addin examples. Remove --enable-nacl and --no-sandbox from PPAPI plugin runs. Remove unneeded/harmful .user file. BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1456

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Messages

Total messages: 4 (0 generated)
Sam Clegg
8 years, 4 months ago (2012-10-18 23:18:48 UTC) #1
binji
lgtm, but I think --wait-for-debugger-children is not a NaCl flag. Not sure what it does, ...
8 years, 4 months ago (2012-10-18 23:26:35 UTC) #2
Sam Clegg
ptal I also include the change to use the DLL CRT libs by default.
8 years, 4 months ago (2012-10-18 23:49:20 UTC) #3
Sam Clegg
8 years, 4 months ago (2012-10-19 00:56:15 UTC) #4
On 2012/10/18 23:49:20, Sam Clegg wrote:
> ptal
> 
> I also include the change to use the DLL CRT libs by default.

Ok.  Dhould be good to go now.  The CRT question seems to have
been answered now and the initial config was correct.

Powered by Google App Engine
This is Rietveld 408576698