Issue 1122293002: Disallow hashless hex color quirk for non integer <number>

Issue 1122293002: Disallow hashless hex color quirk for non integer <number> (Closed)

Created:
5 years, 7 months ago by rwlbuis

Modified:
5 years, 7 months ago

Reviewers:
Timothy Loh

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Disallow hashless hex color quirk for non integer <number> Step 2.1 in the hashless hex color quirk algorithm [1] says: If component value type flag is not "integer", return an error. So when handling <number> make sure to test that the component value is an integer, discard the property otherwise. [1] https://quirks.spec.whatwg.org/#the-hashless-hex-color-quirk BUG=439050 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194951

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -1 line)			Patch
	M	LayoutTests/fast/css/parsing-color-quirk.html	View	1	2 chunks	+28 lines, -1 line	0 comments	Download
	M	Source/core/css/parser/CSSPropertyParser.cpp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122293002/40001

5 years, 7 months ago (2015-05-05 23:59:23 UTC) #7

commit-bot: I haz the power

5 years, 7 months ago (2015-05-06 01:33:45 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194951