fixes #158, precendence of call and access in new

lib/src/js/printer.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_ast;
 
 
 class JavaScriptPrintingOptions {
   final bool shouldCompressOutput;
   final bool minifyLocalVariables;
@@ skipping 42 matching lines @@
 
 class Printer implements NodeVisitor {
   final JavaScriptPrintingOptions options;
   final JavaScriptPrintingContext context;
   final bool shouldCompressOutput;
   final DanglingElseVisitor danglingElseVisitor;
   final LocalNamer localNamer;
 
   bool inForInit = false;
   bool atStatementBegin = false;
+  bool inNewTarget = false;
   bool pendingSemicolon = false;
   bool pendingSpace = false;
 
   // The current indentation level.
   int _indentLevel = 0;
   // A cache of all indentation strings used so far.
   List<String> _indentList = <String>[""];
 
   static final identifierCharacterRegExp = new RegExp(r'^[a-zA-Z_0-9$]');
   static final expressionContinuationRegExp = new RegExp(r'^[-+([]');
@@ skipping 480 matching lines @@
         // for (a = (x in o); ... ; ... ) { ... }
         (newInForInit && node is Binary && node.op == "in") ||
         // (function() { ... })().
         // ({a: 2, b: 3}.toString()).
         (newAtStatementBegin && (node is NamedFunction ||
                                  node is FunctionExpression ||
                                  node is ObjectInitializer));
     if (needsParentheses) {
       inForInit = false;
       atStatementBegin = false;
+      inNewTarget = false;
       out("(");
       visit(node);
       out(")");
     } else {
       inForInit = newInForInit;
       atStatementBegin = newAtStatementBegin;
       visit(node);
     }
   }
 
@@ skipping 36 matching lines @@
                           newInForInit: false, newAtStatementBegin: false);
     spaceOut();
     out(":");
     spaceOut();
     visitNestedExpression(cond.otherwise, ASSIGNMENT,
                           newInForInit: inForInit, newAtStatementBegin: false);
   }
 
   visitNew(New node) {
     out("new ");
+    inNewTarget = true;
     visitNestedExpression(node.target, ACCESS,
                           newInForInit: inForInit, newAtStatementBegin: false);
+    inNewTarget = false;
     out("(");
     visitCommaSeparated(node.arguments, ASSIGNMENT,
                         newInForInit: false, newAtStatementBegin: false);
     out(")");
   }
 
   visitCall(Call call) {
     visitNestedExpression(call.target, LEFT_HAND_SIDE,
                           newInForInit: inForInit,
                           newAtStatementBegin: atStatementBegin);
@@ skipping 171 matching lines @@
       }
     }
 
     // TODO(floitsch): normally we should also check that the field is not a
     // reserved word.  We don't generate fields with reserved word names except
     // for 'super'.
     return options.allowKeywordsInProperties || field != '"super"';
   }
 
   visitAccess(PropertyAccess access) {
-    visitNestedExpression(access.receiver, CALL,
+    // Normally we can omit parens on the receiver if it is a Call, even though
+    // Call expressions have lower precedence. However this optimization doesn't
+    // work inside New expressions:
+    //
+    //     new obj.foo().bar()
+    //
+    // This will be parsed as:
+    //
+    //     (new obj.foo()).bar()
+    //
+    // Which is incorrect. So we must have parenthesis in this case:
+    //
+    //     new (obj.foo()).bar()
+    //
+    int precedence = inNewTarget ? ACCESS : CALL;
+
+    visitNestedExpression(access.receiver, precedence,
                           newInForInit: inForInit,
                           newAtStatementBegin: atStatementBegin);
     propertyNameOut(access.selector, inAccess: true);
   }
 
   visitNamedFunction(NamedFunction namedFunction) {
     functionOut(namedFunction.function, namedFunction.name);
   }
 
   visitFun(Fun fun) {
@@ skipping 592 matching lines @@
     declare(node.name);
     node.function.accept(this);
   }
 
   visitClassExpression(ClassExpression node) {
     declare(node.name);
     if (node.heritage != null) node.heritage.accept(this);
     for (Method element in node.methods) element.accept(this);
   }
 }