Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1122283002: fixes #158, precendence of call and access in new (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly
Modified:
5 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix comment #

Patch Set 3 : redesgin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -39 lines) Patch
M lib/runtime/dart/_internal.js View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M lib/runtime/dart/async.js View 1 2 6 chunks +10 lines, -10 lines 0 comments Download
M lib/runtime/dart/collection.js View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M lib/runtime/dart/core.js View 1 2 6 chunks +12 lines, -12 lines 0 comments Download
M lib/runtime/dart/isolate.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/js/printer.dart View 1 2 4 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 7 months ago (2015-05-05 18:35:06 UTC) #2
vsm
lgtm
5 years, 7 months ago (2015-05-05 21:51:42 UTC) #3
Jennifer Messerly
5 years, 7 months ago (2015-05-05 21:55:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
37a95d08e06c84fd7fe7ad2570243ce0804df1fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698