Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1122253002: Replace v8::Handle with v8::Local in InjectedScriptBase. (Closed)

Created:
5 years, 7 months ago by hyunjunekim2
Modified:
5 years, 7 months ago
Reviewers:
haraken, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace v8::Handle with v8::Local in InjectedScriptBase. Replace v8::Handle with v8::Local in InjectedScriptBase. Because v8::Handle is an alias of v8::Local. BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/inspector/InjectedScriptBase.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
hyunjunekim2
Hi, I'm hyunjunekim (hyunjune.kim@samsung.com, hykim0777@gamil.com). Could you check this patch? Thank you.
5 years, 7 months ago (2015-05-05 13:05:00 UTC) #1
yurys
lgtm
5 years, 7 months ago (2015-05-05 13:09:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122253002/1
5 years, 7 months ago (2015-05-05 13:16:30 UTC) #7
haraken
LGTM
5 years, 7 months ago (2015-05-05 15:56:05 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 16:46:52 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194928

Powered by Google App Engine
This is Rietveld 408576698