Issue 1122173002: App launcher: Avoid a browser crash if the custom page renderer crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1122173002: App launcher: Avoid a browser crash if the custom page renderer crashes. (Closed)

Created:
5 years, 7 months ago by Matt Giuca

Modified:
5 years, 7 months ago

Reviewers:
calamity

CC:
chromium-reviews, tfarina, tapted, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2357

Target Ref:
refs/pending/branch-heads/2357

Project:
chromium

Visibility:
Public.

App launcher: Avoid a browser crash if the custom page renderer crashes. BUG=482395 Review URL: https://codereview.chromium.org/1115093002 Cr-Commit-Position: refs/heads/master@{#327658} (cherry picked from commit ba91feb584df4f1b660b651406279df1d8798580) TBR=calamity@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/fb5ae2925b8c7ff2f8cbe21a8d47ceba87eb1e9b

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/ui/app_list/app_list_view_delegate.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Total messages: 3 (1 generated)

Matt Giuca

5 years, 7 months ago (2015-05-05 05:06:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fb5ae2925b8c7ff2f8cbe21a8d47ceba87eb1e9b (presubmit successful).