Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: base/trace_event/trace_event_unittest.cc

Issue 1122153002: Fixit: Fork base::TimeTicks --> TimeTicks + ThreadTicks + TraceTicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FIXIT_timeclasses_1of2
Patch Set: Comment tweaks in base/time/time.h Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/trace_event_unittest.cc
diff --git a/base/trace_event/trace_event_unittest.cc b/base/trace_event/trace_event_unittest.cc
index d03224301cdffd3367bf85165832ff2e901f7152..81861a481bcb94c7fa101e554d6f82183e590a01 100644
--- a/base/trace_event/trace_event_unittest.cc
+++ b/base/trace_event/trace_event_unittest.cc
@@ -2250,10 +2250,10 @@ class TraceEventCallbackTest : public TraceEventTestFixture {
std::vector<std::string> collected_events_categories_;
std::vector<std::string> collected_events_names_;
std::vector<unsigned char> collected_events_phases_;
- std::vector<TimeTicks> collected_events_timestamps_;
+ std::vector<TraceTicks> collected_events_timestamps_;
static TraceEventCallbackTest* s_instance;
- static void Callback(TimeTicks timestamp,
+ static void Callback(TraceTicks timestamp,
char phase,
const unsigned char* category_group_enabled,
const char* name,
@@ -2452,11 +2452,9 @@ TEST_F(TraceEventTestFixture, TraceBufferVectorReportFull) {
trace_log->CreateTraceBufferVectorOfSize(100));
do {
TRACE_EVENT_BEGIN_WITH_ID_TID_AND_TIMESTAMP0(
- "all", "with_timestamp", 0, 0,
- TimeTicks::NowFromSystemTraceTime().ToInternalValue());
+ "all", "with_timestamp", 0, 0, TraceTicks::Now().ToInternalValue());
TRACE_EVENT_END_WITH_ID_TID_AND_TIMESTAMP0(
- "all", "with_timestamp", 0, 0,
- TimeTicks::NowFromSystemTraceTime().ToInternalValue());
+ "all", "with_timestamp", 0, 0, TraceTicks::Now().ToInternalValue());
} while (!trace_log->BufferIsFull());
EndTraceAndFlush();
@@ -2928,7 +2926,7 @@ TEST_F(TraceEventTestFixture, EchoToConsoleTraceEventRecursion) {
TEST_F(TraceEventTestFixture, TimeOffset) {
BeginTrace();
// Let TraceLog timer start from 0.
- TimeDelta time_offset = TimeTicks::NowFromSystemTraceTime() - TimeTicks();
+ TimeDelta time_offset = TraceTicks::Now() - TraceTicks();
TraceLog::GetInstance()->SetTimeOffset(time_offset);
{
@@ -2936,17 +2934,15 @@ TEST_F(TraceEventTestFixture, TimeOffset) {
TRACE_EVENT0("all", "duration2");
}
TRACE_EVENT_BEGIN_WITH_ID_TID_AND_TIMESTAMP0(
- "all", "with_timestamp", 0, 0,
- TimeTicks::NowFromSystemTraceTime().ToInternalValue());
+ "all", "with_timestamp", 0, 0, TraceTicks::Now().ToInternalValue());
TRACE_EVENT_END_WITH_ID_TID_AND_TIMESTAMP0(
- "all", "with_timestamp", 0, 0,
- TimeTicks::NowFromSystemTraceTime().ToInternalValue());
+ "all", "with_timestamp", 0, 0, TraceTicks::Now().ToInternalValue());
EndTraceAndFlush();
DropTracedMetadataRecords();
double end_time = static_cast<double>(
- (TimeTicks::NowFromSystemTraceTime() - time_offset).ToInternalValue());
+ (TraceTicks::Now() - time_offset).ToInternalValue());
double last_timestamp = 0;
for (size_t i = 0; i < trace_parsed_.GetSize(); ++i) {
const DictionaryValue* item;

Powered by Google App Engine
This is Rietveld 408576698