components/favicon/core/BUILD.gn - Issue 1122103003: [Large Icon Service] Move icon resizing into worker thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/BUILD.gn

Issue 1122103003: [Large Icon Service] Move icon resizing into worker thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make Session a class; make using callback chain functions static. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/favicon/core/BUILD.gn

diff --git a/components/favicon/core/BUILD.gn b/components/favicon/core/BUILD.gn

index f4e8a15e34a53e056c4e683e01a5bf8a974845bc..fefec690f0db57fcc7a2034562267075244b161f 100644

--- a/components/favicon/core/BUILD.gn

+++ b/components/favicon/core/BUILD.gn

@@ -29,6 +29,7 @@ static_library("core") {

"//components/favicon_base",

"//components/history/core/browser",

"//components/keyed_service/core",

+ "//content/public/browser",

jochen (gone - plz use gerrit) 2015/05/07 15:00:41 why does the gypi version not also need this depen

huangs 2015/05/07 21:01:58 Added.

"//skia",

"//ui/base",

"//ui/gfx",

« no previous file with comments | « no previous file | components/favicon/core/DEPS » ('j') | components/favicon/core/large_icon_service.h » ('J')