components/favicon.gypi - Issue 1122103003: [Large Icon Service] Move icon resizing into worker thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon.gypi

Issue 1122103003: [Large Icon Service] Move icon resizing into worker thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Inject caller's task runner to Session; fix tests by mocking GetBackgroundTaskRunner(). Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/favicon.gypi

diff --git a/components/favicon.gypi b/components/favicon.gypi

index d2f9195e04a3c428230a2e2b7921360695f90028..f7666ec97643234184f0575f1a148f8721e7c53e 100644

--- a/components/favicon.gypi

+++ b/components/favicon.gypi

@@ -10,6 +10,7 @@

'type': 'static_library',

'dependencies': [

'../base/base.gyp:base',

+ '../content/content.gyp:content_browser',

'../skia/skia.gyp:skia',

'../ui/base/ui_base.gyp:ui_base',

'../ui/gfx/gfx.gyp:gfx',

« no previous file with comments | « no previous file | components/favicon/core/BUILD.gn » ('j') | components/favicon/core/large_icon_service.h » ('J')