components/favicon/core/DEPS - Issue 1122103003: [Large Icon Service] Move icon resizing into worker thread.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/favicon/core/DEPS

Issue 1122103003: [Large Icon Service] Move icon resizing into worker thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment cleanup; making ResizeLargeIconOnBackgroundThreadIfValid() a member function. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/bookmarks/browser",	2 "+components/bookmarks/browser",

3 "+components/history/core/browser",	3 "+components/history/core/browser",

4 "+components/keyed_service/core",	4 "+components/keyed_service/core",

	5 "+content/public/browser",
	blundell 2015/07/22 15:53:35 This is actually a dependency that shouldn't have This is actually a dependency that shouldn't have been introduced here: see the README in //components/favicon. It should be easy to inject the SequencedWorkerPool into LargeIconService via the //chrome-level factory instead of using content::BrowserThread directly here.
5 "+skia",	6 "+skia",

6 "+third_party/skia",	7 "+third_party/skia",

7 "+third_party/skia/include",	8 "+third_party/skia/include",

8 "+ui/gfx",	9 "+ui/gfx",

9 ]	10 ]

OLD	NEW

« no previous file with comments | « components/favicon/core/BUILD.gn ('k') | components/favicon/core/large_icon_service.h » ('j') | no next file with comments »