[Large Icon Service] Move icon resizing into worker thread.

components/favicon/core/large_icon_service.h

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_FAVICON_CORE_LARGE_ICON_SERVICE_H_
 #define COMPONENTS_FAVICON_CORE_LARGE_ICON_SERVICE_H_
 
 #include <vector>
 
+#include "base/memory/ref_counted.h"
 #include "base/task/cancelable_task_tracker.h"
+#include "base/threading/thread_checker.h"
 #include "components/favicon_base/favicon_callback.h"
 #include "components/keyed_service/core/keyed_service.h"
 
 class GURL;
 
+namespace base {
+class TaskRunner;
+}
+
 namespace favicon_base {
 struct FaviconRawBitmapResult;
 }
 
 namespace favicon {
 
 class FaviconService;
 
 // The large icon service provides methods to access large icons. It relies on
 // the favicon service.
@@ skipping 17 matching lines @@
 
  private:
   // Resizes |bitmap_result| to |desired_size_in_pixel|x|desired_size_in_pixel|.
   // Stores the resized bitmap data in |resized_bitmap_result| and returns true
   // if successful.
   bool ResizeLargeIconIfValid(
       int desired_size_in_pixel,
       const favicon_base::FaviconRawBitmapResult& bitmap_result,
       favicon_base::FaviconRawBitmapResult* resized_bitmap_result);
 
-  // Intermediate callback for GetLargeIconOrFallbackStyle(). Tries to resize
-  // |bitmap_result| and pass the output to |callback|. If that does not work,
-  // computes the icon fallback style and uses it to invoke |callback|.
-  void RunLargeIconCallback(
+  // Tries to resize |bitmap_result| and pass the output to |callback|. If that
+  // does not work, computes the icon fallback style and uses it to invoke
+  // |callback|. The work is done on a background thread since image resizing
+  // can be expensive, and should not occur on the UI thread.
+  void RunLargeIconCallbackOnBackgroundThread(
       const favicon_base::LargeIconCallback& callback,
       int desired_size_in_pixel,
       const favicon_base::FaviconRawBitmapResult& bitmap_result);
 
+  // Intermediate callback for GetLargeIconOrFallbackStyle().

[beaudoin, 2015/05/05 00:00:52]

// Meant to be invoked on the UI thread, this should not perform complex image
operations.

[huangs, 2015/05/05 15:22:13]

Done.

+  void RunLargeIconCallback(
+      const favicon_base::LargeIconCallback& callback,
+      int desired_size_in_pixel,
+      base::CancelableTaskTracker* tracker,
+      const favicon_base::FaviconRawBitmapResult& bitmap_result);
+
+  // Return the TaskRunner used to execute background task.
+  scoped_refptr<base::TaskRunner> GetBackgroundTaskRunner();
+
   FaviconService* favicon_service_;
 
   // A pre-populated list of the types of icon files to consider when looking
   // for large icons. This is an optimization over populating an icon type
   // vector on each request.
   std::vector<int> large_icon_types_;
 
+  base::ThreadChecker thread_checker_;
+
   DISALLOW_COPY_AND_ASSIGN(LargeIconService);
 };
 
 }  // namespace favicon
 
 #endif  // COMPONENTS_FAVICON_CORE_LARGE_ICON_SERVICE_H_