Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1453)

Unified Diff: src/isolate.h

Issue 1122083002: Remove materialized objects on stack unwind. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Tweaks, do not unwind the handler's frame Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index 37d832d25d36783d2db482f1aff22407a041b622..749eb4fd57bd58d382642ba5eb2c2066071ab025 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -764,7 +764,7 @@ class Isolate {
// Find the correct handler for the current pending exception. This also
// clears and returns the current pending exception.
- Object* FindHandler();
+ Object* UnwindAndFindHandler();
// Tries to predict whether an exception will be caught. Note that this can
// only produce an estimate, because it is undecidable whether a finally
@@ -1254,6 +1254,10 @@ class Isolate {
// then return true.
bool PropagatePendingExceptionToExternalTryCatch();
+ // Remove per-frame stored materialized objects when we are unwinding
+ // the frame.
+ void RemoveMaterializedObjectsOnUnwind(StackFrame* frame);
+
// Traverse prototype chain to find out whether the object is derived from
// the Error object.
bool IsErrorObject(Handle<Object> obj);
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698