Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Side by Side Diff: src/arm64/code-stubs-arm64.cc

Issue 1122083002: Remove materialized objects on stack unwind. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Tweaks, do not unwind the handler's frame Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/deoptimizer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1185 matching lines...) Expand 10 before | Expand all | Expand 10 after
1196 Isolate::kPendingHandlerCodeAddress, isolate()); 1196 Isolate::kPendingHandlerCodeAddress, isolate());
1197 ExternalReference pending_handler_offset_address( 1197 ExternalReference pending_handler_offset_address(
1198 Isolate::kPendingHandlerOffsetAddress, isolate()); 1198 Isolate::kPendingHandlerOffsetAddress, isolate());
1199 ExternalReference pending_handler_fp_address( 1199 ExternalReference pending_handler_fp_address(
1200 Isolate::kPendingHandlerFPAddress, isolate()); 1200 Isolate::kPendingHandlerFPAddress, isolate());
1201 ExternalReference pending_handler_sp_address( 1201 ExternalReference pending_handler_sp_address(
1202 Isolate::kPendingHandlerSPAddress, isolate()); 1202 Isolate::kPendingHandlerSPAddress, isolate());
1203 1203
1204 // Ask the runtime for help to determine the handler. This will set x0 to 1204 // Ask the runtime for help to determine the handler. This will set x0 to
1205 // contain the current pending exception, don't clobber it. 1205 // contain the current pending exception, don't clobber it.
1206 ExternalReference find_handler(Runtime::kFindExceptionHandler, isolate()); 1206 ExternalReference find_handler(Runtime::kUnwindAndFindExceptionHandler,
1207 isolate());
1207 DCHECK(csp.Is(masm->StackPointer())); 1208 DCHECK(csp.Is(masm->StackPointer()));
1208 { 1209 {
1209 FrameScope scope(masm, StackFrame::MANUAL); 1210 FrameScope scope(masm, StackFrame::MANUAL);
1210 __ Mov(x0, 0); // argc. 1211 __ Mov(x0, 0); // argc.
1211 __ Mov(x1, 0); // argv. 1212 __ Mov(x1, 0); // argv.
1212 __ Mov(x2, ExternalReference::isolate_address(isolate())); 1213 __ Mov(x2, ExternalReference::isolate_address(isolate()));
1213 __ CallCFunction(find_handler, 3); 1214 __ CallCFunction(find_handler, 3);
1214 } 1215 }
1215 1216
1216 // We didn't execute a return case, so the stack frame hasn't been updated 1217 // We didn't execute a return case, so the stack frame hasn't been updated
(...skipping 4534 matching lines...) Expand 10 before | Expand all | Expand 10 after
5751 kStackUnwindSpace, NULL, spill_offset, 5752 kStackUnwindSpace, NULL, spill_offset,
5752 MemOperand(fp, 6 * kPointerSize), NULL); 5753 MemOperand(fp, 6 * kPointerSize), NULL);
5753 } 5754 }
5754 5755
5755 5756
5756 #undef __ 5757 #undef __
5757 5758
5758 } } // namespace v8::internal 5759 } } // namespace v8::internal
5759 5760
5760 #endif // V8_TARGET_ARCH_ARM64 5761 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/deoptimizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698