Remove materialized objects on stack unwind.

Remove materialized objects on stack unwind.

BUG=v8:3985
LOG=n
R=mstarzinger@chromium.org

Committed: https://crrev.com/b5b47e1f88dffaf9f22944ba085715077a3cdd61
Cr-Commit-Position: refs/heads/master@{#28206}

[Jarin, 2015-05-04 14:36:07]

Could you take a look, please?

[Jarin, 2015-05-04 14:38:45]

On 2015/05/04 14:36:07, jarin wrote:
> Could you take a look, please?

To be honest, I am not quite happy about mutating state in a method that is only
supposed to find things (Isolate::FindHandler), so perhaps it would be better to
rename the function. (FindHandlerAndUnwindFrames or some such.) What do you
think?

[Michael Starzinger, 2015-05-04 15:17:03]

LGTM with one comments to address.

https://codereview.chromium.org/1122083002/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/1122083002/diff/1/src/isolate.cc#newcode1046
src/isolate.cc:1046: RemoveMaterializedObjectsOnUnwind(frame);
As discussed offline: I think the materialized objects should only be discarded
if we didn't find an exception handler. Otherwise the exception handler might
lazy deopt and still need the materialized objects.

[Jarin, 2015-05-04 16:23:32]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2015-05-04 16:23:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1122083002/#ps20001
(title: "Tweaks, do not unwind the handler's frame")

[commit-bot: I haz the power, 2015-05-04 16:23:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1122083002/20001

[commit-bot: I haz the power, 2015-05-04 16:44:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-04 16:44:17]

Patchset 2 (id:??) landed as
https://crrev.com/b5b47e1f88dffaf9f22944ba085715077a3cdd61
Cr-Commit-Position: refs/heads/master@{#28206}