Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1122043003: Reverting all rolls in: https://build.chromium.org/p/chromium/builders/Win/builds/31562 (Closed)

Created:
5 years, 7 months ago by Dan Beam
Modified:
5 years, 7 months ago
Reviewers:
tdresser
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reverting all rolls in: https://build.chromium.org/p/chromium/builders/Win/builds/31562 To see if it fixes "sizes" issues of setup.exe (which increased by 0.43%). Revert "Roll src/third_party/skia edae309:973d1f1" This reverts commit 2618188d7cd94ad9d91005ae40b8b5b43c17fd55. Revert "Roll src/third_party/WebKit 44bf010:b6264e0 (svn 194864:194869)" This reverts commit c942d1fa06a461bf27045111aa9dc12de712c995. Revert "NaCl: Update revision in DEPS, 660eb1e -> 204c16e" This reverts commit 06b37d88372e54e9bbde76a0b6fc7e2176e22397. R=tdresser@chromium.org TBR=tdresser@chromium.org BUG=none TEST=green win sizes Committed: https://chromium.googlesource.com/chromium/src/+/d558f46c34085abfc9f59824fdc3466f45c40152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M DEPS View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dan Beam
5 years, 7 months ago (2015-05-04 20:21:47 UTC) #1
tdresser
On 2015/05/04 20:21:47, Dan Beam wrote: LGTM
5 years, 7 months ago (2015-05-04 20:23:33 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d558f46c34085abfc9f59824fdc3466f45c40152 Cr-Commit-Position: refs/heads/master@{#328178}
5 years, 7 months ago (2015-05-04 20:26:22 UTC) #3
Dan Beam
Committed patchset #1 (id:1) manually as d558f46c34085abfc9f59824fdc3466f45c40152 (presubmit successful).
5 years, 7 months ago (2015-05-04 20:26:46 UTC) #4
Dan Beam
5 years, 7 months ago (2015-05-04 21:41:30 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1126693002/ by dbeam@chromium.org.

The reason for reverting is: None of these rolls were the issue :(.

Powered by Google App Engine
This is Rietveld 408576698