Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1122033002: Migrate error messages, part 7. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Migrate error messages, part 7. R=mvstanton@chromium.org Committed: https://crrev.com/a3ddb1bc428bf74b79b77143d1abb9f8862b2f9e Cr-Commit-Position: refs/heads/master@{#28216}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -50 lines) Patch
M src/arraybuffer.js View 1 chunk +1 line, -1 line 0 comments Download
M src/collection.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/harmony-array.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-regexp.js View 1 chunk +1 line, -2 lines 0 comments Download
M src/harmony-typedarray.js View 1 chunk +1 line, -3 lines 0 comments Download
M src/messages.h View 3 chunks +19 lines, -1 line 0 comments Download
M src/messages.js View 2 chunks +0 lines, -14 lines 0 comments Download
M src/object-observe.js View 7 chunks +16 lines, -17 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-typedarray.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/typedarray.js View 1 chunk +1 line, -1 line 0 comments Download
M src/weak-collection.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/messages.js View 5 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
Yang
5 years, 7 months ago (2015-05-04 09:54:35 UTC) #1
mvstanton
lgtm
5 years, 7 months ago (2015-05-04 16:29:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122033002/1
5 years, 7 months ago (2015-05-04 16:35:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/84) v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 7 months ago (2015-05-04 16:36:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122033002/20001
5 years, 7 months ago (2015-05-05 06:51:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/93)
5 years, 7 months ago (2015-05-05 06:52:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122033002/40001
5 years, 7 months ago (2015-05-05 07:03:27 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-05 07:57:43 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/a3ddb1bc428bf74b79b77143d1abb9f8862b2f9e Cr-Commit-Position: refs/heads/master@{#28216}
5 years, 7 months ago (2015-05-05 07:57:50 UTC) #16
Yang
5 years, 7 months ago (2015-05-05 09:54:06 UTC) #17
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1120333007/ by yangguo@chromium.org.

The reason for reverting is: layout test failures..

Powered by Google App Engine
This is Rietveld 408576698