Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 112203006: rebaseline gm self-tests after https://code.google.com/p/skia/source/detail?r=12850 (Closed)

Created:
6 years, 11 months ago by epoger
Modified:
6 years, 11 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com, tfarina
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline gm self-tests after https://code.google.com/p/skia/source/detail?r=12850 The GM self-test's fragility is already noted in https://code.google.com/p/skia/issues/detail?id=1068 ('make gm self-test more robust') NOTRY=True NOTREECHECKS=True TBR=mtklein Committed: http://code.google.com/p/skia/source/detail?r=12885

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M gm/tests/outputs/add-config-pdf/output-expected/stdout View 1 chunk +1 line, -0 lines 1 comment Download
M gm/tests/outputs/checksum-based-filenames/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-images/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-json/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-images/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-json/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-images/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-json/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tests/outputs/ignore-expectations-mismatch/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tests/outputs/ignoring-one-test/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tests/outputs/ignoring-some-failures/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tests/outputs/intentionally-skipped-tests/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tests/outputs/no-hierarchy/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tests/outputs/no-readpath/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tests/outputs/pipe-playback-failure/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
https://codereview.chromium.org/112203006/diff/1/gm/tests/outputs/add-config-pdf/output-expected/stdout File gm/tests/outputs/add-config-pdf/output-expected/stdout (right): https://codereview.chromium.org/112203006/diff/1/gm/tests/outputs/add-config-pdf/output-expected/stdout#newcode7 gm/tests/outputs/add-config-pdf/output-expected/stdout:7: GM: reading resources from resources I have confirmed that ...
6 years, 11 months ago (2014-01-03 16:36:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/112203006/1
6 years, 11 months ago (2014-01-03 16:37:03 UTC) #2
commit-bot: I haz the power
Change committed as 12885
6 years, 11 months ago (2014-01-03 16:37:23 UTC) #3
mtklein
On 2014/01/03 16:37:03, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 11 months ago (2014-01-03 16:38:09 UTC) #4
epoger
6 years, 11 months ago (2014-01-03 16:40:34 UTC) #5
Message was sent while issue was closed.
On 2014/01/03 16:38:09, mtklein wrote:
> On 2014/01/03 16:37:03, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> > https://skia-tree-status.appspot.com/cq/epoger%2540google.com/112203006/1
> 
> lgtm.  Is there a bot that runs this?

Yes, http://108.170.217.252:10117/builders/Housekeeper-PerCommit .  It's been
red since
http://108.170.217.252:10117/builders/Housekeeper-PerCommit/builds/2773

Powered by Google App Engine
This is Rietveld 408576698