components/autofill/content/renderer/password_autofill_agent.cc - Issue 112203003: Fix renderer crashes when frame gets detached while injectng user scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 112203003: Fix renderer crashes when frame gets detached while injectng user scripts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated patch to latest WebFrame/Frame lifetime changes. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/user_script_slave.cc ('K') | « components/autofill/content/renderer/page_click_tracker.cc ('k') | content/renderer/render_view_browsertest.cc » ('j') | content/renderer/render_view_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_autofill_agent.cc

diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc

index 81a822ad84d6f5525602acdad47cb59c784ed9a1..25063a748e13a2d355f4644eacae722e034335d7 100644

--- a/components/autofill/content/renderer/password_autofill_agent.cc

+++ b/components/autofill/content/renderer/password_autofill_agent.cc

@@ -359,7 +359,7 @@ void PasswordAutofillAgent::SendPasswordForms(blink::WebFrame* frame,

bool only_visible) {

// Make sure that this security origin is allowed to use password manager.

blink::WebSecurityOrigin origin = frame->document().securityOrigin();

- if (!OriginCanAccessPasswordManager(origin))

+ if (origin.isNull() || !OriginCanAccessPasswordManager(origin))

return;

// Checks whether the webpage is a redirect page or an empty page.