content/renderer/render_view_impl.cc - Issue 112203003: Fix renderer crashes when frame gets detached while injectng user scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 112203003: Fix renderer crashes when frame gets detached while injectng user scripts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added render view browser tests that perform synchronous frame removal on loading finished. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 82567ede99a6d08a95f396901c3dbb99530086ee..eb109de770ba4c42c84c4c5c8ffdf1093ddff499 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -3786,7 +3786,8 @@ void RenderViewImpl::didFinishDocumentLoad(WebFrame* frame) {

DidFinishDocumentLoad(frame));

// Check whether we have new encoding name.

- UpdateEncoding(frame, frame->view()->pageEncoding().utf8());

+ if (frame->view())

+ UpdateEncoding(frame, frame->view()->pageEncoding().utf8());

}

void RenderViewImpl::didHandleOnloadEvents(WebFrame* frame) {

« content/renderer/render_view_browsertest.cc ('K') | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »