Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1121993004: Inference through conditional expressions (Closed)

Created:
5 years, 7 months ago by Leaf
Modified:
5 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Inference through conditional expressions. Push type info down through conditional expressions. This eliminates some casts (mostly due to a bug in the analyzer lub code). BUG= R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/6ed20fe9a2c6cb35bcea0a37bf390c1b0f6771ec

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -129 lines) Patch
M lib/runtime/dart/_interceptors.js View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 3 chunks +4 lines, -4 lines 0 comments Download
M lib/runtime/dart/async.js View 5 chunks +6 lines, -19 lines 0 comments Download
M lib/runtime/dart/collection.js View 1 9 chunks +12 lines, -12 lines 0 comments Download
M lib/runtime/dart/convert.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M lib/runtime/dart/core.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
M lib/src/checker/rules.dart View 1 3 chunks +12 lines, -2 lines 0 comments Download
M test/checker/checker_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
M test/dart_codegen/expect/async/stream_controller.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/async/zone.dart View 10 chunks +19 lines, -32 lines 0 comments Download
M test/dart_codegen/expect/collection/splay_tree.dart View 9 chunks +17 lines, -23 lines 0 comments Download
M test/dart_codegen/expect/convert/json.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/convert/utf.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/core/errors.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/core/exceptions.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/core/iterable.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/core/list.dart View 7 chunks +11 lines, -11 lines 0 comments Download
M test/dart_codegen/expect/core/stopwatch.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/core/uri.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Leaf
5 years, 7 months ago (2015-05-04 23:36:16 UTC) #2
vsm
lgtm
5 years, 7 months ago (2015-05-05 14:01:21 UTC) #3
Leaf
5 years, 7 months ago (2015-05-05 17:47:48 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6ed20fe9a2c6cb35bcea0a37bf390c1b0f6771ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698