Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1121853002: fixes #150, broken code in js_number.dart (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly
Modified:
5 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M lib/runtime/dart/_interceptors.js View 1 chunk +1 line, -1 line 0 comments Download
M test/generated_sdk/lib/_internal/compiler/js_lib/js_number.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/private/js_number.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
5 years, 7 months ago (2015-05-01 21:23:00 UTC) #2
Jennifer Messerly
5 years, 7 months ago (2015-05-01 21:23:02 UTC) #3
vsm
lgtm
5 years, 7 months ago (2015-05-01 21:36:25 UTC) #4
Jennifer Messerly
5 years, 7 months ago (2015-05-01 21:37:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
346952c7eed6a77f12453aca73686328efd9ff11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698