Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1121833003: [V8] Reland https://codereview.chromium.org/1100993003/ (Closed)

Created:
5 years, 7 months ago by kozy
Modified:
5 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/scanner.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
kozy
Yang, please take a look.
5 years, 7 months ago (2015-05-05 10:30:48 UTC) #1
Yang
lgtm
5 years, 7 months ago (2015-05-05 10:58:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121833003/1
5 years, 7 months ago (2015-05-05 14:19:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 14:21:12 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/19b62e211d1829108e5c85c5043dd755afa17178 Cr-Commit-Position: refs/heads/master@{#28229}
5 years, 7 months ago (2015-05-05 14:21:23 UTC) #6
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1125113003/ by machenbach@chromium.org. ...
5 years, 7 months ago (2015-05-06 06:59:24 UTC) #7
Michael Achenbach
The revert helped. Please land a blink-side NeedsManualRebaseline expectation change first before relanding, if the ...
5 years, 7 months ago (2015-05-06 08:31:25 UTC) #8
Michael Achenbach
Hmm - I can see that there was an expectation change already. I'll investigate why ...
5 years, 7 months ago (2015-05-06 09:58:57 UTC) #9
Michael Achenbach
The layout test expectation changes miss one test: virtual/slimmingpaint/svg/dom/SVGViewSpec.html
5 years, 7 months ago (2015-05-06 10:00:29 UTC) #10
Michael Achenbach
5 years, 7 months ago (2015-05-06 10:27:45 UTC) #11
Message was sent while issue was closed.
This also breaks Threading2 on arm debug without vfp3:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim...

The root cause might be somewhere else, but please investigate before relanding.

Powered by Google App Engine
This is Rietveld 408576698