Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1121823004: Add some basic UMA for proxy service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix histogram descriptions. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « net/proxy/proxy_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 1f7ad6f405204985db0851d3ca630e044b32d33f..16da7312bc0b73b3a9069e7bb75ea9c360f2f17a 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -20344,6 +20344,40 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<summary>The length of the URL that was passed into the PAC script.</summary>
</histogram>
+<histogram name="Net.ProxyService.GetProxyUsingScriptTime">
+ <owner>eroman@chromium.org</owner>
+ <summary>
+ The time taken to resolve a URL by forwarding the request to the proxy
+ resolver and executing the PAC script. This includes PAC script execution,
+ DNS queries, and retries.
eroman 2015/05/12 00:48:51 nit: retries is somewhat ambiguous. There is anoth
Anand Mistry (off Chromium) 2015/05/12 03:07:25 I've changed the wording a bit to clarify that the
+ </summary>
+</histogram>
+
+<histogram name="Net.ProxyService.ResolvedUsingScript">
+ <owner>eroman@chromium.org</owner>
+ <summary>
+ Whether proxy resolution occured by forwarding the request to the proxy
+ resolver and executing the PAC script.
eroman 2015/05/12 00:48:50 nit: there are exceptions: if the --winhttp-proxy-
Anand Mistry (off Chromium) 2015/05/12 03:07:25 I've added some wording to point this out, without
+ </summary>
+</histogram>
+
+<histogram name="Net.ProxyService.ResolveProxyTime">
+ <owner>eroman@chromium.org</owner>
+ <summary>
+ The total time taken to resolve a URL. This includes PAC script execution,
+ DNS queries, and retries.
+ </summary>
+</histogram>
+
+<histogram name="Net.ProxyService.ScriptTerminated">
+ <owner>eroman@chromium.org</owner>
+ <summary>
+ Whether a proxy resolution resulted in the PAC script terminating
+ unexpectedly. This happens when the resolver process crashes when using
+ out-of-process PAC.
+ </summary>
+</histogram>
+
<histogram name="Net.PublicKeyPinFailureDomain" enum="PublicKeyPinFailedDomain">
<owner>agl@chromium.org</owner>
<summary>
« no previous file with comments | « net/proxy/proxy_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698