|
|
Created:
5 years, 7 months ago by tfarina Modified:
5 years, 7 months ago CC:
blink-reviews, dglazkov+blink Base URL:
svn://svn.chromium.org/blink/trunk Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionAdd blink_unittests target.
This is needed to avoid colision (specially in GN) with Chromium's
blink_tests targets.
See https://codereview.chromium.org/1118863002/ for how this came along.
BUG=483171
TEST=gyp_chromium and gn gen out-gn/Debug
R=dpranke@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194841
Patch Set 1 #Patch Set 2 : REBASE #Patch Set 3 : another try? what is happening with ui_chromeos_unittests on linux gn? #Patch Set 4 : again #Patch Set 5 : rm the gn part #Messages
Total messages: 32 (16 generated)
lgtm.
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121753003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
The CQ bit was checked by tfarina@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1121753003/#ps20001 (title: "REBASE")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121753003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121753003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
The CQ bit was checked by tfarina@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1121753003/#ps40001 (title: "another try? what is happening with ui_chromeos_unittests on linux gn?")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121753003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
The CQ bit was checked by tfarina@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1121753003/#ps60001 (title: "again")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121753003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
dcheng@chromium.org changed reviewers: + dcheng@chromium.org
How about blink_unittests instead of blink_test_binaries? Also, please send out a PSA about these kind of changes? I build the blunk_tests targets a lot and this would have caught me completely by surprise.
Yeah, blink_unittests sounds good. Then I can get to webkit_unit_tests -> web_unittests. I will send a PSA when this land.
The CQ bit was checked by tfarina@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1121753003/#ps80001 (title: "rm the gn part")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121753003/80001
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://src.chromium.org/viewvc/blink?view=rev&revision=194841 |