Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1121753003: Add blink_test_binaries target. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke, dcheng
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add blink_unittests target. This is needed to avoid colision (specially in GN) with Chromium's blink_tests targets. See https://codereview.chromium.org/1118863002/ for how this came along. BUG=483171 TEST=gyp_chromium and gn gen out-gn/Debug R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194841

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : another try? what is happening with ui_chromeos_unittests on linux gn? #

Patch Set 4 : again #

Patch Set 5 : rm the gn part #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M public/all.gyp View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (16 generated)
tfarina
5 years, 7 months ago (2015-05-01 22:41:42 UTC) #1
Dirk Pranke
lgtm.
5 years, 7 months ago (2015-05-01 22:42:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121753003/1
5 years, 7 months ago (2015-05-01 23:39:49 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/34599)
5 years, 7 months ago (2015-05-02 00:23:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121753003/20001
5 years, 7 months ago (2015-05-02 00:26:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/34603)
5 years, 7 months ago (2015-05-02 00:35:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121753003/20001
5 years, 7 months ago (2015-05-02 01:03:06 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/34605)
5 years, 7 months ago (2015-05-02 01:08:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121753003/40001
5 years, 7 months ago (2015-05-02 01:11:47 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/34607)
5 years, 7 months ago (2015-05-02 01:23:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121753003/60001
5 years, 7 months ago (2015-05-02 02:44:51 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/34610)
5 years, 7 months ago (2015-05-02 02:52:03 UTC) #25
dcheng
How about blink_unittests instead of blink_test_binaries? Also, please send out a PSA about these kind ...
5 years, 7 months ago (2015-05-02 03:07:30 UTC) #27
tfarina
Yeah, blink_unittests sounds good. Then I can get to webkit_unit_tests -> web_unittests. I will send ...
5 years, 7 months ago (2015-05-02 03:16:02 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121753003/80001
5 years, 7 months ago (2015-05-02 14:56:14 UTC) #31
commit-bot: I haz the power
5 years, 7 months ago (2015-05-02 18:51:18 UTC) #32
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194841

Powered by Google App Engine
This is Rietveld 408576698