Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1121723004: Fix focus visibility and style for GAIA Back and Close buttons (Closed)

Created:
5 years, 7 months ago by Greg Levin
Modified:
5 years, 7 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix focus visibility and style for GAIA Back and Close buttons BUG=478429, 478545 The Back and Close buttons are now styled as per https://code.google.com/p/chromium/issues/detail?id=478545#c9 There is no animated ripple effect, and they do not use polymer, but are otherwise in line with the requests of this issue. Fixes apply to both regular login and Enterprise Enrollment flows. Committed: https://crrev.com/b916ecb5d789e40c97c8b1ddaec9ea1ee029cad6 Cr-Commit-Position: refs/heads/master@{#328849}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -29 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment_webview.css View 2 chunks +4 lines, -12 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment_webview.html View 2 chunks +6 lines, -2 lines 1 comment Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.css View 3 chunks +31 lines, -15 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
Greg Levin
Please have a look https://codereview.chromium.org/1121723004/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment_webview.html File chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment_webview.html (right): https://codereview.chromium.org/1121723004/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment_webview.html#newcode85 chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment_webview.html:85: i18n-values="aria-label:closeButton" tabindex="0"></button> Moved down here ...
5 years, 7 months ago (2015-05-06 00:23:58 UTC) #2
Nikita (slow)
I'll let Pavel dzhioev@ review this CL since he's now in MTV timezone.
5 years, 7 months ago (2015-05-07 12:30:17 UTC) #4
dzhioev (left Google)
On 2015/05/07 12:30:17, Nikita wrote: > I'll let Pavel dzhioev@ review this CL since he's ...
5 years, 7 months ago (2015-05-07 20:51:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121723004/1
5 years, 7 months ago (2015-05-07 21:13:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 22:00:50 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 22:02:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b916ecb5d789e40c97c8b1ddaec9ea1ee029cad6
Cr-Commit-Position: refs/heads/master@{#328849}

Powered by Google App Engine
This is Rietveld 408576698