Source/bindings/tests/results/core/V8TestSpecialOperations.cpp - Issue 1121703002: bindings: Uses V8's named property interceptor for Window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

Issue 1121703002: bindings: Uses V8's named property interceptor for Window. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Synced. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestObject.cpp ('k') | Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

diff --git a/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp b/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

index 1c538cc4fe0830c6f985801a43ce184ab3e07a40..4ca8cde709ccf8c319d95182552f3f7297398b15 100644

--- a/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

+++ b/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

@@ -178,8 +178,8 @@ static void installV8TestSpecialOperationsTemplate(v8::Local<v8::FunctionTemplat

v8::Local<v8::ObjectTemplate> prototypeTemplate = functionTemplate->PrototypeTemplate();

ALLOW_UNUSED_LOCAL(prototypeTemplate);

{

- v8::NamedPropertyHandlerConfiguration config(TestSpecialOperationsV8Internal::namedPropertyGetterCallback, TestSpecialOperationsV8Internal::namedPropertySetterCallback, TestSpecialOperationsV8Internal::namedPropertyQueryCallback, 0, TestSpecialOperationsV8Internal::namedPropertyEnumeratorCallback);

- config.flags = static_cast<v8::PropertyHandlerFlags>(static_cast<int>(config.flags) | static_cast<int>(v8::PropertyHandlerFlags::kOnlyInterceptStrings));

+ int flags = static_cast<int>(v8::PropertyHandlerFlags::kOnlyInterceptStrings);

+ v8::NamedPropertyHandlerConfiguration config(TestSpecialOperationsV8Internal::namedPropertyGetterCallback, TestSpecialOperationsV8Internal::namedPropertySetterCallback, TestSpecialOperationsV8Internal::namedPropertyQueryCallback, 0, TestSpecialOperationsV8Internal::namedPropertyEnumeratorCallback, v8::Handle<v8::Value>(), static_cast<v8::PropertyHandlerFlags>(flags));

functionTemplate->InstanceTemplate()->SetHandler(config);

}